torrc parser in stem

Arm has a pretty nice parser and validator for Tor's torrc... https://gitweb.torproject.org/arm.git/blob/HEAD:/src/util/torConfig.py

We should port it and the man page parser over to stem, adding tests when we do so.

added component::archived/stem controller owner::atagar priority::low resolution::duplicate status::closed type::enhancement labels

Trac:
Keywords: N/A deleted, controller added
Priority: normal to minor
Description: Implement a torrc parser in stem

to

Arm has a pretty nice parser and validator for Tor's torrc... https://gitweb.torproject.org/arm.git/blob/HEAD:/src/util/torConfig.py

We should port it and the man page parser over to stem, adding tests when we do so.

A very simple Torrc parser, not in stem's standards by any measure. I just made this for my needs. Thought it might be useful if I push it upstream in case anyone wants to expand on this.

https://gitweb.torproject.org/user/gsathya/stem.git/commitdiff/0b7c415642257faec9ec3212717a961eaf1ec8f6?hp=0d01ad60bb2a4ea2f0ac1f9626360d5db22858ea

Hi Sathyanarayanan. That would be a fine start for a feature branch but I'd rather not merge it until we have something a bit more complete and with tests.

Btw, on first glance your parser will break when it encounters blank lines...

with open(torrc_path) as torrc_fh:
  for line in torrc_fh.readlines():
    line = line.strip()
    if line.startswith('#'):
      continue
    else:
      key, val = line.split(' ')
      torrc[key] = val

>>> line = ""
>>> if line.startswith('#'):
...   pass
... else:
...   key, val = line.split(' ')
... 
Traceback (most recent call last):
  File "<stdin>", line 4, in <module>
ValueError: need more than 1 value to unpack

Hey, thanks for the review. Yep, this is super trivial as I mentioned, definitely not good enough to be merged. I will try to work on this more, but no promises.

Resolving in favor of #8251 (closed).

Trac:
Status: new to closed
Resolution: N/A to duplicate

closed

mentioned in issue #8251 (closed)