Opened 6 years ago

Closed 6 years ago

#7692 closed enhancement (implemented)

Backport A1-less GeoIP database

Reported by: karsten Owned by:
Priority: Medium Milestone: Tor: 0.2.2.x-final
Component: Core Tor/Tor Version:
Severity: Keywords:
Cc: nickm, arma, weasel, erinn Actual Points:
Parent ID: Points:
Reviewer: Sponsor:

Description

We should backport the new A1-less GeoIP database file that got recently merged into master (#6266) to previous maintained branches. Two questions:

  • Should we only backport changes to the geoip file (35d09dd, c718921), or should we also include the deanonymind.py script, manual assignment overrides in geoip-manual, and README.geoip (2bf195d) explaining how we created that new geoip file?
  • Should we backport geoip updates to all previous maintained branches (including 0.2.2.x), or will that make package maintainers sad?

Once I know what to backport, I can prepare a branch.

Child Tickets

Change History (4)

comment:1 Changed 6 years ago by nickm

I favor backporting only the geoip file.

I think, IIUC, that the geopip file updates do no bug package maintainers. Weasel, please correct me if I'm wrong.

comment:2 Changed 6 years ago by weasel

It might be fine to update while we're updating other things.

I am not convinced it's a reason to release updates to our stable trees all by itself.

Agreed on updating only the geoip file - the changelog can document how we create it.

comment:3 in reply to:  2 Changed 6 years ago by karsten

Status: newneeds_review

Replying to weasel:

It might be fine to update while we're updating other things.

I am not convinced it's a reason to release updates to our stable trees all by itself.

Sounds reasonable. In the past, I based geoip updates on maint-0.2.2, they got merged and forward-ported to newer version branches, and whenever enough changes piled up, a release was made containing the most recent database.

Agreed on updating only the geoip file - the changelog can document how we create it.

Okay. Please review my branch task-7692 which is based on maint-0.2.2. That branch has 35d09dd and c718921 cherry-picked and has another commit 6bdfa29 adding a more useful link with explanations how the geoip file was created; referring to the README.geoip file that's only contained in the master branch doesn't make much sense in the maint-* branches.

comment:4 Changed 6 years ago by nickm

Resolution: implemented
Status: needs_reviewclosed

Merged.

Note: See TracTickets for help on using tickets.