Opened 5 years ago

Closed 5 years ago

#7736 closed enhancement (implemented)

additional test cases for stem.response.events module

Reported by: robinson Owned by: atagar
Priority: Medium Milestone:
Component: Core Tor/Stem Version:
Severity: Keywords: testing
Cc: Actual Points:
Parent ID: Points:
Reviewer: Sponsor:

Description

Damian,

Please pull my exp-event-module-tests branch[0], which contains test cases covering most of the events module. This started as tests for the Event class, but I was on a roll. I can make changes or consolidate commits, if you want.

This patch[1] exercises the Event class where its sub-classes do not touch. It highlights the quoted positional arguments discussion[2] we had earlier in the month.

Only AuthDirNewDescEvent has lines which are not tested.. It appears from internal comments that it is not fully working due to an insufficient spec?

[0]: https://gitorious.org/stem-robinson/stem-robinson/commits/exp-event-module-tests
[1]: https://gitorious.org/stem-robinson/stem-robinson/commit/b285c4e661bf2c6345db90710d07d59688e6bbf0
[2]: https://lists.torproject.org/pipermail/tor-dev/2012-December/004244.html

Child Tickets

Change History (1)

comment:1 Changed 5 years ago by atagar

  • Resolution set to implemented
  • Status changed from new to closed

This is fantastic, thanks Sean! Pushed with a few minor revisions...

https://gitweb.torproject.org/stem.git/commitdiff/256676d5e686fb544927a715335c567d693254cc

Note: See TracTickets for help on using tickets.