Opened 7 years ago

Last modified 6 months ago

#7747 new defect

SENDME doesn't need to trigger packaging so aggressively

Reported by: nickm Owned by:
Priority: Medium Milestone: Tor: unspecified
Component: Core Tor/Tor Version:
Severity: Normal Keywords: tor-relay, sendme, nagle, bandwidth, sponsor8-maybe, 034-triage-20180328, 034-removed-20180328, sponsor8-removed
Cc: Actual Points:
Parent ID: Points: 5
Reviewer: Sponsor:

Description

Right now when we process a relay sendme cell, that triggers an attempt to package the stream's inbuf. But that's needlessly aggressive. We could instead have it only attempt to package the stream's inbuf when the window was previously 0, right?

Child Tickets

Change History (9)

comment:1 Changed 7 years ago by nickm

Priority: minornormal

Circuit SENDMES are worse: they make all streams package themselves, which is very overzealous.

comment:2 Changed 2 years ago by nickm

Keywords: sendme nagle data-loss added
Points: 5
Severity: Normal

comment:3 Changed 2 years ago by nickm

Keywords: bandwidth sponsor8-maybe added; data-loss removed

comment:4 Changed 2 years ago by nickm

Milestone: Tor: unspecifiedTor: 0.3.2.x-final
Sponsor: Sponsor8-can

comment:5 Changed 22 months ago by nickm

Milestone: Tor: 0.3.2.x-finalTor: 0.3.4.x-final

comment:6 Changed 16 months ago by nickm

Keywords: 034-triage-20180328 added

comment:7 Changed 16 months ago by nickm

Keywords: 034-removed-20180328 added

Per our triage process, these tickets are pending removal from 0.3.4.

comment:8 Changed 16 months ago by nickm

Milestone: Tor: 0.3.4.x-finalTor: unspecified

These tickets, tagged with 034-removed-*, are no longer in-scope for 0.3.4. We can reconsider any of them, if time permits.

comment:9 Changed 6 months ago by gaba

Keywords: sponsor8-removed added
Sponsor: Sponsor8-can
Note: See TracTickets for help on using tickets.