Opened 6 years ago

Last modified 15 months ago

#7750 new enhancement

Consider packaging inbuf when about to send an end cell

Reported by: nickm Owned by:
Priority: Medium Milestone: Tor: unspecified
Component: Core Tor/Tor Version:
Severity: Normal Keywords: tor-relay data-loss tcp-correctness fin-correctness needs-design
Cc: Actual Points:
Parent ID: Points:
Reviewer: Sponsor:

Description

When we have data we could package from the inbuf, but we're about to send a relay end cell, we don't consider packaging the data. This can degrade performance/correctness of programs that do stuff like sending RSTs when they should be sending FINs.

Reported pseudonymously. This has been an issue with basically all versions of Tor AFAICT, so at least it's not a recent regression.

Child Tickets

Change History (2)

comment:1 Changed 15 months ago by nickm

Keywords: tcp-correctness fin-correctness needs-design added
Severity: Normal

This change may be a good idea, but we shouldn't do this new behavior unconditionally: only when we're sending an END cell because we received a FIN.

comment:2 Changed 15 months ago by nickm

Keywords: data-loss added
Note: See TracTickets for help on using tickets.