Opened 7 years ago

Closed 6 years ago

#7751 closed defect (implemented)

torspec: Announce name of active pluggable transport through the Extended ORPort

Reported by: asn Owned by:
Priority: Medium Milestone: Tor: 0.2.5.x-final
Component: Core Tor/Tor Version:
Severity: Keywords: pt tor-spec tor-client
Cc: Actual Points:
Parent ID: #5040 Points:
Reviewer: Sponsor:

Description

obfsproxy should let Tor know which pluggable transport is used on a connection, so that Tor can keep statistics on the number of people using each transport.

Child Tickets

Attachments (1)

0001-Fix-numbering-of-TRANSPORT-section.patch (812 bytes) - added by dcf 6 years ago.

Download all attachments as: .zip

Change History (11)

comment:1 Changed 7 years ago by asn

Status: newneeds_review

Check out branch bug7751 in https://git.torproject.org/user/asn/torspec.git.

comment:2 Changed 7 years ago by asn

Actually, check out branch bug7751 in https://git.torproject.org/user/asn/torspec.git.

The strings don't need to be NUL-terminated since the Extended ORPort command structure specifies the payload length.

comment:3 Changed 7 years ago by asn

Ugh, the above should read:
Check out branch bug7751_take2 in https://git.torproject.org/user/asn/torspec.git.

comment:4 Changed 7 years ago by nickm

Milestone: Tor: unspecifiedTor: 0.2.5.x-final

Looks okay, but some more info would help. Is there any description about what action Tor should take based on this information, what format the names should have, whether they need to be nul-terminated, what it means for a transport to have a name, etc, etc?

comment:5 Changed 7 years ago by asn

Updated the branch.
Please see branch bug7751_take2 in https://git.torproject.org/user/asn/torspec.git again.

comment:6 Changed 7 years ago by nickm

Keywords: tor-spec added; torspec removed

Bulk-replacing "spec" and "torspec" keywords with "tor-spec".

comment:7 Changed 6 years ago by nickm

Keywords: tor-client added

comment:8 Changed 6 years ago by dcf

Little section numbering bug: 3.1.2.1 is used twice.

comment:9 Changed 6 years ago by asn

Fixed.

I didn't see your patch and I just did it on my own. Sorry.

comment:10 Changed 6 years ago by nickm

Resolution: implemented
Status: needs_reviewclosed

squashed & merged. Thanks!

Note: See TracTickets for help on using tickets.