Opened 8 years ago

Closed 8 years ago

#7754 closed defect (fixed)

Fix build and correctness issues with MSVC

Reported by: nickm Owned by:
Priority: Medium Milestone: Tor: 0.2.4.x-final
Component: Core Tor/Tor Version:
Severity: Keywords: tor-client msvc
Cc: ultramage Actual Points:
Parent ID: Points:
Reviewer: Sponsor:

Description

This is a parent ticket for various MSVC issues that ultramage has been finding and reporting.

Child Tickets

TicketStatusOwnerSummaryComponent
#7304closedtor_snprintf instead of snprintfCore Tor/Tor
#7305closedenum variables with defined bit widthCore Tor/Tor
#7308closedlibevent used uninitialized on faulty code pathCore Tor/Tor
#7309closednmake script wrong main build target output filenameCore Tor/Tor
#7310closednmake script LIBS variable uses .a instead of .libCore Tor/Tor
#7311closednmake scripts missing platform dependencies for opensslCore Tor/Tor
#7312closednmake scripts missing include ../ext pathCore Tor/Tor
#7313closedmsvc compilation error for libevent2, missing HAVE_EVENT2_DNS_HCore Tor/Tor
#7315closednmake script outdated list of source filesCore Tor/Tor
#7316closednmake script for tests missing build targetsCore Tor/Tor
#7669closedSIZEOF_INTPTR_T not defined in msvc buildsCore Tor/Tor

Change History (4)

comment:1 Changed 8 years ago by nickm

Cc: ultramage added
Keywords: msvc added
Status: newneeds_review

All of these (except #7311 and maybe #7304) should be fixed in branch "024_msvc" in my public repository.

Please review?

comment:2 Changed 8 years ago by nickm

All of these should be in 024_msvc.

This branch needs more review and testing, though! Please review and test so I can merge.

comment:3 Changed 8 years ago by nickm

Andrea says it looks good to here; I'll take one more good look then merge.

comment:4 Changed 8 years ago by nickm

Resolution: fixed
Status: needs_reviewclosed

Okay, merged. This tranche of MSVC bugs is now closed.

Note: See TracTickets for help on using tickets.