Opened 6 years ago

Last modified 2 years ago

#7755 new defect

circuit_t::timestamp_dirty should be cleaned up

Reported by: rransom Owned by:
Priority: Medium Milestone: Tor: unspecified
Component: Core Tor/Tor Version:
Severity: Normal Keywords: tor-client intro refactor technical-debt
Cc: Actual Points:
Parent ID: Points: parent
Reviewer: Sponsor:

Description

circuit_t::timestamp_dirty is used in multiple bizarre ways, which should be reverse-engineered, documented, and cleaned up (probably by replacing it with multiple fields, each with a name which reflects its actual meaning and/or purpose). See also the #7157 review discussion.

Also, is there a good reason for it to be in circuit_t, not origin_circuit_t? (Any use of it on or_circuit_ts (or even on service-side rendezvous origin_circuit_ts) would have different semantics.)

Child Tickets

TicketStatusOwnerSummaryComponent
#6174closedDe-kludgify marking circs as unsuitable for new streamsCore Tor/Tor
#7802closedRemove PathBias use of timestamp_dirty and record usage accountingCore Tor/Tor

Change History (2)

comment:1 Changed 6 years ago by nickm

Keywords: tor-client added

comment:2 Changed 2 years ago by nickm

Keywords: intro refactor technical-debt added
Points: parent
Severity: Normal
Note: See TracTickets for help on using tickets.