Opened 7 years ago

Closed 6 years ago

#7764 closed defect (duplicate)

Reimplement circuit_get_by_rend_token_and_purpose with an associative array

Reported by: nickm Owned by:
Priority: Medium Milestone: Tor: 0.2.5.x-final
Component: Core Tor/Tor Version:
Severity: Keywords: tor-relay
Cc: Actual Points:
Parent ID: #7727 Points:
Reviewer: Sponsor:

Description

circuit_get_by_rend_token_and_purpose showed up in mo's profile on #7727. It was only 3% of overall runtime, but that's still more than we ought to be burning on a dumb linear search.

Child Tickets

Change History (4)

comment:1 Changed 7 years ago by nickm

Status: newneeds_review

possible untested fix in branch rend_token_map. It needs documentation. Checkpointing here.

comment:2 Changed 7 years ago by nickm

Milestone: Tor: 0.2.4.x-finalTor: 0.2.5.x-final

No tests? This isn't ready for 0.2.4, Nick.

comment:3 Changed 6 years ago by nickm

Status: needs_reviewneeds_revision

comment:4 Changed 6 years ago by nickm

Resolution: duplicate
Status: needs_revisionclosed

Looks like I did this one more time, in a branch called "bug9841_024" for #9841. Closing this as a dup, since my comments there are smarter.

Note: See TracTickets for help on using tickets.