Opened 7 years ago

Closed 6 years ago

#7766 closed task (fixed)

Add xsltproc to the list of asciidoc-helper's Debian packages

Reported by: dcf Owned by:
Priority: Very Low Milestone: Tor: 0.2.4.x-final
Component: Core Tor/Tor Version:
Severity: Keywords:
Cc: onizuka.xxxx@… Actual Points:
Parent ID: Points:
Reviewer: Sponsor:

Description

When I build Tor on a new machine, I install the recommended docbook-xsl, docbook-xml, and libxl2-utils, and asciidoc still doesn't work. I have to remember that the other package I need is xsltproc, so let's add it to the list.

Child Tickets

Attachments (1)

Add-xsltproc-to-asciidoc-helper.patch (2.2 KB) - added by dcf 7 years ago.

Download all attachments as: .zip

Change History (6)

Changed 7 years ago by dcf

comment:1 Changed 6 years ago by onizuka

Cc: onizuka.xxxx@… added
Status: newneeds_review
Type: defecttask

comment:2 Changed 6 years ago by nickm

Milestone: Tor: 0.2.4.x-final

comment:3 Changed 6 years ago by weasel

The .deb build depends on asciidoc (>= 8.2), docbook-xml, docbook-xsl, xmlto.

I suggest we add xmlto to the list in asciidoc-helper.sh:

diff --git a/doc/asciidoc-helper.sh b/doc/asciidoc-helper.sh
index dd420f7..c06b570 100755
--- a/doc/asciidoc-helper.sh
+++ b/doc/asciidoc-helper.sh
@@ -52,8 +52,8 @@ elif [ "$1" = "man" ]; then
 You need a working asciidoc installed to be able to build the manpage.
 
 a2x is installed, but for some reason it isn't working.  Sometimes
-This happens because required docbook support files are missing.
-Please install docbook-xsl, docbook-xml, and libxml2-utils (Debian) or
+this happens because required docbook support files are missing.
+Please install docbook-xsl, docbook-xml, and xmlto (Debian) or
 similar. If you use homebrew on Mac OS X, install the docbook formula
 and add "export XML_CATALOG_FILES=/usr/local/etc/xml/catalog" to your
 .bashrc

comment:4 in reply to:  3 Changed 6 years ago by dcf

Replying to weasel:

The .deb build depends on asciidoc (>= 8.2), docbook-xml, docbook-xsl, xmlto.

I suggest we add xmlto to the list in asciidoc-helper.sh:

diff --git a/doc/asciidoc-helper.sh b/doc/asciidoc-helper.sh
index dd420f7..c06b570 100755
--- a/doc/asciidoc-helper.sh
+++ b/doc/asciidoc-helper.sh
@@ -52,8 +52,8 @@ elif [ "$1" = "man" ]; then
 You need a working asciidoc installed to be able to build the manpage.
 
 a2x is installed, but for some reason it isn't working.  Sometimes
-This happens because required docbook support files are missing.
-Please install docbook-xsl, docbook-xml, and libxml2-utils (Debian) or
+this happens because required docbook support files are missing.
+Please install docbook-xsl, docbook-xml, and xmlto (Debian) or
 similar. If you use homebrew on Mac OS X, install the docbook formula
 and add "export XML_CATALOG_FILES=/usr/local/etc/xml/catalog" to your
 .bashrc

I have installed xsltproc but not xmlto, and building the man page works for me. But it looks like xmlto depends on both xsltproc and libxml2-utils, so this looks good.

comment:5 Changed 6 years ago by nickm

Resolution: fixed
Status: needs_reviewclosed

great; I applied that in commit aa051b7573d4b7ab9867560b190808d5e67a34c7 . Thanks!

Note: See TracTickets for help on using tickets.