Opened 11 years ago

#777 closed defect (Fixed)

Torbutton is become untranslated when Tor is activated whith US Spoofing.

Reported by: mfr Owned by:
Priority: Low Milestone:
Component: Applications/Torbutton Version: 1.2.0rc5
Severity: Keywords:
Cc: mfr Actual Points:
Parent ID: Points:
Reviewer: Sponsor:

Description

[12:00:23] <mfr> In fact I mean all the torbutton is now in english
[12:00:39] <mikeperry> woah
[12:00:41] <mfr> I'm on the last release of course ;-)
[12:00:55] <mikeperry> before you file a bug report, can you try a few previous releases?
[12:01:03] <mikeperry> and see if it's something new?
[12:01:16] <mfr> i can do that
[12:01:24] <mikeperry> you can find old ones in https://torbutton.torproject.org/dev/releases/
[12:01:27] <mikeperry> I appreciate it
[12:01:30] <mikeperry> thanks
[12:04:55] <mfr> Ok i've found were is the problem
[12:05:20] <mfr> It's probably on the spoofing US nav fonctionality
[12:05:36] <mfr> functionality
[12:08:04] <mikeperry> does the issue depend on which tor state the browser starts in?
[12:09:04] <mfr> Yes
[12:09:40] <mfr> If you're 'Tor' and you change apparence ==> all in english
[12:10:02] <mikeperry> it changes instantly?
[12:10:12] <mfr> If you're 'Not Tor' and you change apparence no problem.
[12:10:15] <mikeperry> or just on firefox restart?
[12:10:25] <mfr> Yes its instantly
[12:10:40] <mfr> but whan you restart good langage is back
[12:10:47] <mikeperry> damn. ff2, ff3, or both?
[12:12:48] <mfr> The bug test is changing button to image or image to button Tor activated with US Spoofing.
[12:13:03] <mfr> on ff2 last vers
[12:13:09] <mfr> untedted on ff3
[12:14:23] <mikeperry> how are you choosing the locale in the first place? via environment variable, command line argument, or firefox option?
[12:14:31] <mfr> both in rc5 and 6
[12:14:55] <mfr> it's a standard firefox i think
[12:15:19] <mfr> lang default for french ( fr fr_FR en en_US)
[12:20:37] <mfr> I think that the torbutton dosn't take at the good place in the firefox model is display language value
[22:49:57] <mfr> so what can i do for that ?
[23:55:53] <mikeperry> it could be because torbutton is touching the pref 'intl.accept_languages', but I'm surprised that is being used to choose the UI language
[23:56:02] <mikeperry> I thought it was only for what got sent to websites
[00:08:36] <mikeperry> can you verify if that is the setting causing you the problems?
[09:07:31] <mfr> yes i've seen that torbutton is touching 'intl.accept_languages'
[09:11:11] <mfr> when i desactivate 'US spoofing option' there is no problems. All strings (with existing translation ;-) ) remain translated even if tor is activated

[Automatically added by flyspray2trac: Operating System: All]

Child Tickets

Attachments (1)

torbutton-1.2.0rc6-dev.xpi (192.2 KB) - added by mikeperry 11 years ago.
Dev snapshot with potential fix

Download all attachments as: .zip

Change History (4)

comment:1 Changed 11 years ago by mikeperry

Hey mfr, let me know if the attached snapshot fixes the issue for you.

Changed 11 years ago by mikeperry

Attachment: torbutton-1.2.0rc6-dev.xpi added

Dev snapshot with potential fix

comment:2 Changed 11 years ago by amis

Awesome

It's ok for the language problem all the torbutton is now in my local language.

Except string of the 776 bug.

You can close it.

comment:3 Changed 11 years ago by mikeperry

flyspray2trac: bug closed.
Fixed in 1.2.0

Note: See TracTickets for help on using tickets.