Opened 11 years ago

#780 closed defect (Fixed)

Update Torbutton extension description to contain warning

Reported by: moglee Owned by:
Priority: High Milestone:
Component: Applications/Torbutton Version: 1.2.0rc5
Severity: Keywords:
Cc: moglee Actual Points:
Parent ID: Points:
Reviewer: Sponsor:

Description

The Torbutton extension, on installation, removes all persistent cookies. It also modifies several browser options.
These do NOT get restored on the extension being uninstalled, even if you install, realize you dont like it and
immediately uninstall. If you have del.icio.us installed, installing Torbutton leads to a strange dialog "You have been
logged out of del.icio.us. Please decide whether or not to delete your bookmarks" If you have a GMail window open,
it too logs out. This is extremely disruptive from a user point of view. What is more, removing cookies without asking,
I feel, is a violation of user rights. Accordingly, at the very least, the extension description should be updated to
show a warning explaining this behavior will occur, and workarounds, if any.

[Automatically added by flyspray2trac: Operating System: All]

Child Tickets

Attachments (1)

torbutton-1.2.0rc6-dev.xpi (192.7 KB) - added by mikeperry 11 years ago.
Release that should fix cookie loss issues.

Download all attachments as: .zip

Change History (12)

comment:1 Changed 11 years ago by mikeperry

These should be fixed in the next release. Removing those cookies is not a "violation of user's rights". I'm not
trying to oppress you here. It was just a bug. You can try the attached snapshot and let me know if it fixes your issues.

Changed 11 years ago by mikeperry

Attachment: torbutton-1.2.0rc6-dev.xpi added

Release that should fix cookie loss issues.

comment:2 Changed 11 years ago by mikeperry

Btw, the delcious issue will happen whenever you clear your cookies. you should file a bug with them for an option
to disable that message.

Also, you will be logged out of gmail during Tor usage, but the cookies should be restored during non-tor usage.

comment:3 Changed 11 years ago by moglee

Sorry for losing it a bit :) I would like to confirm that the cookie loss issue still exists with the attached version. On a side note, while normal cookies get cleared out, Flash player cookies stay. You can check for this from the fact that the Yahoo Sign In Seal manages to retain the attached image and color etc.

comment:4 Changed 11 years ago by mikeperry

Wait, do you allow plugins during Tor usgae? They should normally be disabled..

comment:5 Changed 11 years ago by moglee

I don't understand... The clearing of cookies occurs the moment the browser restarts, after Torbutton installation.
That is well before enabling Torbutton to use the Tor network. (Tor is not enabled by default after Torbutton installs)
Am I supposed to manually disable all plugins before installing Torbutton?

comment:6 Changed 11 years ago by mikeperry

Hrmm.. so you say that the cookie clearing issue was not fixed for installation? Are you sure about
that? Do you have any other extensions installed? I've noticed that CookieCuller is destroying my
cookies in Firefox 3 during restart. Perhaps that is your problem?

I was asking about plugins because of your flash cookies. Those should not persist into your Tor state
because all plugins should be disabled during Tor. They will remain during Non-Tor usage though,
of course.

comment:7 Changed 11 years ago by mikeperry

If you go to about:config, what is the value of network.cookie.lifetimePolicy? is it possible that got
set to 2 somehow?

comment:8 Changed 11 years ago by moglee

network.cookie.lifetimePolicy is at 0 (default), network.cookie.lifetime.days is at 90 (default).

I wanted to see if one of the extensions was causing an issue. So I started Firefox with a new profile, installed the
delicious extension, logged into GMail. Intalled TorButton and restarted. My cookies were NOT cleared out.

Possibly some preference in the old profile from the earlier version of the extension, or as you say, conflict with one
of the other extensions is causing the issue. I guess you can close this :)

comment:9 Changed 11 years ago by mikeperry

Hrmm, that is still a little weird. I will close this bug and put out 1.2.0, but if you do find the conflict, please
file a new bug for that.

Also, if you get a chance, could you also update your a.m.o review if the session cookies and other cookie issues
end up being fixed to your satisfaction?

comment:10 Changed 11 years ago by mikeperry

Oh, and in your review, please encourage others to use this bug system. It is very disappointing to me to have to
read vague bad reviews on a.m.o that I can't even comment on or help people fix. I am very attentive to fixing
bugs, but only if I can correspond and get details from people (which a.m.o review board specifically prevents).

comment:11 Changed 11 years ago by mikeperry

flyspray2trac: bug closed.
Fixed in 1.2.0. Any remaining issues are addon conflicts and should be seperate bug(s).

Note: See TracTickets for help on using tickets.