Opened 7 years ago

Closed 5 years ago

Last modified 4 years ago

#7803 closed defect (fixed)

Clients shouldn't send timestamps in INTRODUCE1 cells

Reported by: rransom Owned by:
Priority: High Milestone: Tor: 0.2.6.x-final
Component: Core Tor/Tor Version:
Severity: Keywords: tor-hs, 025-triaged, 2016-bug-retrospective
Cc: Actual Points:
Parent ID: Points:
Reviewer: Sponsor: SponsorR

Description

0.2.3.x (and later) stable releases don't look at the timestamp field. As soon as 0.2.2.x is EOLed, clients should stop sending timestamps (send (time_t)0 instead).

Child Tickets

Change History (14)

comment:1 Changed 7 years ago by nickm

Keywords: tor-hs added

comment:2 Changed 6 years ago by nickm

Priority: normalmajor

comment:3 Changed 6 years ago by nickm

Parent ID: #9767

f8b44eedf725cadb15 starts to work on this, as discussed in proposal 222. For now, we send a rounded time. Once we flip the switch in the consensus, we'll send no time at all.

I'm leaving this open until we flip that switch.

comment:4 in reply to:  3 Changed 6 years ago by andrea

Replying to nickm:

f8b44eedf725cadb15 starts to work on this, as discussed in proposal 222. For now, we send a rounded time. Once we flip the switch in the consensus, we'll send no time at all.

I'm leaving this open until we flip that switch.

Triage: are we going to be ready to flip your switch in time for 0.2.5.x?

comment:5 Changed 6 years ago by nickm

It's quite plausible; 0.2.2 should be dead in a few months. Let's see how fast 0.2.5.x stabilizes.

comment:6 Changed 6 years ago by nickm

Parent ID: #9767

comment:7 Changed 6 years ago by nickm

Keywords: 025-triaged added

comment:8 Changed 5 years ago by nickm

This kinda belongs in a hypothetical "directory authority action" component.

comment:9 Changed 5 years ago by arma

Milestone: Tor: 0.2.5.x-finalTor: 0.2.6.x-final

So, do we set Support022HiddenServices=0 in the consensus, change the meaning of auto in 0.2.6, and close the ticket (assuming nothing catches fire during these steps)?

comment:10 Changed 5 years ago by arma

Keywords: SponsorR added

comment:11 Changed 5 years ago by arma

Sebastian and I have now set Support022HiddenServices=0 on our respective dir auths

comment:12 Changed 5 years ago by nickm

Resolution: fixed
Status: newclosed

Okay. Now that it's on, I'm removing the option in 0.2.6, with commit b3bd7a736c7a54406c087bfaa2bae3dec03ec7bd

comment:13 Changed 4 years ago by dgoulet

Keywords: SponsorR removed
Sponsor: SponsorR

comment:14 Changed 4 years ago by nickm

Keywords: 2016-bug-retrospective added

Mark more tickets for severe bug retrospective, based on Priority and date and hand-inspection.

Note: See TracTickets for help on using tickets.