Opened 7 years ago

Closed 5 years ago

#7816 closed defect (fixed)

Various resource leaks in various parts of Tor (found by coverity scan)

Reported by: nickm Owned by:
Priority: Medium Milestone: Tor: 0.2.4.x-final
Component: Core Tor/Tor Version:
Severity: Keywords: tor-relay coverity leak 023-backport
Cc: weasel Actual Points:
Parent ID: Points:
Reviewer: Sponsor:

Description

We've got coverity running on our code again, and predictably, it's found a few resource leaks. Most are leak-on-hard-to-trigger-error cases, but one or two are repeating leaks on a successful operation.

This is an omnibus ticket for the lot of them, so I can point to something and say "please review this."

Child Tickets

Change History (6)

comment:1 Changed 7 years ago by nickm

Status: newneeds_review

Please review "bug7816_023" and "bug7816_024" for fixes on 0.2.3 and 0.2.4. Only two of the memory leaks happen in Tor under regular operation on a happy machine. I say we merge them all (pending review) in 0.2.4, and consider whether those two are backport material for 0.2.3.

comment:2 Changed 7 years ago by nickm

Merged bug7816_024 after review by Andrea.

comment:3 Changed 7 years ago by nickm

Cc: weasel added
Keywords: 023-backport added
Milestone: Tor: 0.2.4.x-finalTor: 0.2.3.x-final

Merged bug7816_023 into master, but not into 0.2.3. Waiting to hear what weasel thinks of that.

comment:4 Changed 7 years ago by nickm

Added another leak fix to bug7816_023, and to master.

comment:5 Changed 7 years ago by arma

Let's look at weasel's comment on #8718 to decide what to do with the two 'active' leaks here.

comment:6 Changed 5 years ago by nickm

Milestone: Tor: 0.2.3.x-finalTor: 0.2.4.x-final
Resolution: fixed
Status: needs_reviewclosed

Marking a batch of tickets that had been under consideration for 0.2.3 backport as fixed-in-0.2.4. There is no plan for further 0.2.3 releases.

Note: See TracTickets for help on using tickets.