Opened 7 years ago

Closed 7 years ago

#7833 closed defect (fixed)

Target ONLINE fails prior to tor version 0.2.2.9

Reported by: atagar Owned by: atagar
Priority: Low Milestone:
Component: Archived/Stem Version:
Severity: Keywords: testing
Cc: Actual Points:
Parent ID: Points:
Reviewer: Sponsor:

Description

Calling EXTENDCIRCUIT requires a path prior to tor version 0.2.2.9. This breaks all of our new_circuit() and extend_circuit() calls, breaking the tests if we run with the ONLINE target.

======================================================================
                    test.integ.control.controller                     
======================================================================

test_attachstream                                            [FAILURE]
test_authenticate                                            [SUCCESS]
test_close_circuit                                           [FAILURE]
test_enable_feature                                          [SUCCESS]
test_event_handling                                          [SUCCESS]
test_extendcircuit                                           [FAILURE]
test_from_port                                               [SUCCESS]
test_from_socket_file                                        [SUCCESS]
test_get_circuits                                            [FAILURE]
test_get_network_status (https://trac.torproject.org/7163)   [SKIPPED]
test_get_network_statuses                                    [SUCCESS]
test_get_server_descriptor (https://trac.torproject.org/7163)[SKIPPED]
test_get_server_descriptors                                  [SUCCESS]
test_get_socks_ports                                         [SUCCESS]
test_get_version                                             [SUCCESS]
test_getconf                                                 [SUCCESS]
test_getinfo                                                 [SUCCESS]
test_loadconf                                                [SUCCESS]
test_mapaddress                                              [SUCCESS]
test_protocolinfo                                            [SUCCESS]
test_reattaching_listeners                                   [SUCCESS]
test_repurpose_circuit                                       [FAILURE]
test_saveconf                                                [SUCCESS]
test_set_conf                                                [SUCCESS]
test_signal                                                  [SUCCESS]

======================================================================
ERROR: test_attachstream
----------------------------------------------------------------------
Traceback:
  File "/home/atagar/Desktop/stem/test/integ/control/controller.py", line 745, in test_attachstream
    circuit_id = controller.new_circuit()
  File "/home/atagar/Desktop/stem/stem/control.py", line 1483, in new_circuit
    return self.extend_circuit(0, path, purpose)
  File "/home/atagar/Desktop/stem/stem/control.py", line 1522, in extend_circuit
    raise stem.InvalidRequest(512, "EXTENDCIRCUIT requires the path prior to version %s" % path_opt_version)
InvalidRequest: EXTENDCIRCUIT requires the path prior to version 0.2.2.9

======================================================================
ERROR: test_close_circuit
----------------------------------------------------------------------
Traceback:
  File "/home/atagar/Desktop/stem/test/integ/control/controller.py", line 567, in test_close_circuit
    circ_id = controller.new_circuit()
  File "/home/atagar/Desktop/stem/stem/control.py", line 1483, in new_circuit
    return self.extend_circuit(0, path, purpose)
  File "/home/atagar/Desktop/stem/stem/control.py", line 1522, in extend_circuit
    raise stem.InvalidRequest(512, "EXTENDCIRCUIT requires the path prior to version %s" % path_opt_version)
InvalidRequest: EXTENDCIRCUIT requires the path prior to version 0.2.2.9

======================================================================
ERROR: test_extendcircuit
----------------------------------------------------------------------
Traceback:
  File "/home/atagar/Desktop/stem/test/integ/control/controller.py", line 522, in test_extendcircuit
    circuit_id = controller.extend_circuit('0')
  File "/home/atagar/Desktop/stem/stem/control.py", line 1522, in extend_circuit
    raise stem.InvalidRequest(512, "EXTENDCIRCUIT requires the path prior to version %s" % path_opt_version)
InvalidRequest: EXTENDCIRCUIT requires the path prior to version 0.2.2.9

======================================================================
ERROR: test_get_circuits
----------------------------------------------------------------------
Traceback:
  File "/home/atagar/Desktop/stem/test/integ/control/controller.py", line 772, in test_get_circuits
    new_circ = controller.new_circuit()
  File "/home/atagar/Desktop/stem/stem/control.py", line 1483, in new_circuit
    return self.extend_circuit(0, path, purpose)
  File "/home/atagar/Desktop/stem/stem/control.py", line 1522, in extend_circuit
    raise stem.InvalidRequest(512, "EXTENDCIRCUIT requires the path prior to version %s" % path_opt_version)
InvalidRequest: EXTENDCIRCUIT requires the path prior to version 0.2.2.9

======================================================================
ERROR: test_repurpose_circuit
----------------------------------------------------------------------
Traceback:
  File "/home/atagar/Desktop/stem/test/integ/control/controller.py", line 544, in test_repurpose_circuit
    circ_id = controller.new_circuit()
  File "/home/atagar/Desktop/stem/stem/control.py", line 1483, in new_circuit
    return self.extend_circuit(0, path, purpose)
  File "/home/atagar/Desktop/stem/stem/control.py", line 1522, in extend_circuit
    raise stem.InvalidRequest(512, "EXTENDCIRCUIT requires the path prior to version %s" % path_opt_version)
InvalidRequest: EXTENDCIRCUIT requires the path prior to version 0.2.2.9

----------------------------------------------------------------------
Ran 25 tests in 24.520s

FAILED

Shutting down tor... done
TESTING FAILED (101 seconds)
  [RUN_OPEN] test_attachstream (test.integ.control.controller.TestController) ... ERROR
  [RUN_OPEN] test_close_circuit (test.integ.control.controller.TestController) ... ERROR
  [RUN_OPEN] test_extendcircuit (test.integ.control.controller.TestController) ... ERROR
  [RUN_OPEN] test_get_circuits (test.integ.control.controller.TestController) ... ERROR
  [RUN_OPEN] test_repurpose_circuit (test.integ.control.controller.TestController) ... ERROR

Child Tickets

Change History (3)

comment:1 in reply to:  description Changed 7 years ago by rransom

Replying to atagar:

Calling EXTENDCIRCUIT requires a path prior to tor version 0.2.2.9.

Don't do that then. Tor 0.2.2.9 is no longer safe to use.

comment:2 Changed 7 years ago by atagar

Yea, guess we might want to simply add a version check to skip these tests if running something ancient.

comment:3 Changed 7 years ago by atagar

Resolution: fixed
Status: newclosed
Note: See TracTickets for help on using tickets.