wouldMatch is not defined -> cookies set in JS not secured

Using Firefox 19 and HTTPS-Everywhere 3.1, the following error appears in the error console about every three (!) seconds:

Error: wouldMatch is not defined Source file: chrome://https-everywhere/content/code/HTTPSRules.js Line: 659

added component::https everywhere/eff-https everywhere owner::pde priority::high resolution::fixed status::closed type::defect version::https-e 3.1.2 labels

Happens in 3.1.2, too.

Trac:
Version: HTTPS-E 3.1 to HTTPS-E 3.1.2

It's possible that due to changes in http-on-modify-request, in Firefox 19, the apocalypse is coming.

Trac:
Summary: Firefox: Error: wouldMatch is not defined to Firefox 19: Error: wouldMatch is not defined
Priority: major to blocker
Cc: N/A to mikeperry

This doesn't happen with all sites, but I can trigger it with HTTPS E 3.1.2, FF 19b2 and a visit to http://nytimes.com.

Trac:
0001-Fixed-call-to-wouldMatch-in-wrong-scope.patch

Patch v1

Trac:
Status: new to needs_review

I take it back. The apocalypse is not coming; this is a stupid bug I introduced by the fix for #7491 (moved). That patch won't do it, I think wouldMatch is actually the wrong thing to be calling.

Trac:
Status: needs_review to accepted

Trac:
Cc: mikeperry to N/A

https://gitweb.torproject.org/https-everywhere.git/commitdiff/7781a436230b9ee0a69c897c94a6a4252ad7e946

Gonna ship and test this in 4.0development.5. In the mean time, 3.1.x is suffering from a regression of #3766 (moved).

Trac:
Priority: blocker to major

Trac:
Summary: Firefox 19: Error: wouldMatch is not defined to wouldMatch is not defined -> cookies set in JS not secured

This should be fixed in 4.0development.5.

Trac:
Resolution: N/A to fixed
Status: accepted to closed

closed

moved to tpo/applications/https-everywhere-eff#7855 (closed)