Opened 7 years ago

Closed 7 years ago

#7861 closed defect (fixed)

atlas should tolerate whitespace in its searches

Reported by: arma Owned by: hellais
Priority: Low Milestone:
Component: Metrics/Relay Search Version:
Severity: Keywords:
Cc: Actual Points:
Parent ID: Points:
Reviewer: Sponsor:

Description

When I paste in e.g. " moria1" to the atlas search box, it tells me there was an internal error. (I do this because I grab it from my cached-descriptors file, and miss by a little bit.)

Seems like it should strip whitespace before and after the query, so it can be more robust to humans.

Child Tickets

Attachments (2)

0001-strip-whitespaces-in-search.patch (700 bytes) - added by gsathya 7 years ago.
0001-strip-whitespaces-in-search.2.patch (701 bytes) - added by gsathya 7 years ago.

Download all attachments as: .zip

Change History (5)

Changed 7 years ago by gsathya

comment:1 Changed 7 years ago by gsathya

Status: newneeds_review

Added patch. Works in Firefox 3.5+, Chrome/Safari 5+, IE9+

Changed 7 years ago by gsathya

comment:2 Changed 7 years ago by karsten

I just tested the second patch. Looks good. Pushed to my branch task-7861 for easier merging. hellais, please merge to master and deploy, or let me know if I should do that. Thanks!

comment:3 Changed 7 years ago by karsten

Resolution: fixed
Status: needs_reviewclosed

Merged and deployed. Closing. Thanks, gsathya!

Note: See TracTickets for help on using tickets.