Opened 6 years ago

Closed 6 years ago

#7896 closed defect (implemented)

Add transport information in boot logs related to bridges

Reported by: asn Owned by:
Priority: Medium Milestone: Tor: 0.2.4.x-final
Component: Core Tor/Tor Version:
Severity: Keywords: tor-client pt
Cc: dcf@… Actual Points:
Parent ID: Points:
Reviewer: Sponsor:

Description

When a Tor client boots with bridges enabled, it spits out some logs related to those bridges:

[Notice] Learned fingerprint 844B1F53FFD548C998F8D3B01B7E19FA07C32222 for bridge 1.2.3.4:5678
[Notice] new bridge descriptor 'bla' (fresh): $844B1F53FFD548C998F8D3B01B7E19FA07C2222~bla at 1.2.3.4

In use cases where we have multiple bridges using multiple pluggable transports, it would be nice if those log messages also mentioned pluggable transport information.

Child Tickets

Change History (3)

comment:1 Changed 6 years ago by asn

Status: newneeds_review

Please see branch bug7896 in https://git.torproject.org/user/asn/tor.git.

It makes:

[Notice] Learned fingerprint 844B1F53FFD548C998F8D3B01B7E19FA07C32222 for bridge 1.2.3.4:5678

look like:

[Notice] Learned fingerprint 844B1F53FFD548C998F8D3B01B7E19FA07C32222 for bridge 1.2.3.4:5678 (with transport 'obfs2').

The problem with this is that that line only appears if we did not know the fpr of the bridge beforehand. If we did know it, that log line will never appear and the user won't know that it connected to that bridge. Maybe we should create another log notice (or info) message that always appears when we manage to connect to a bridge?

comment:2 Changed 6 years ago by dcf

Cc: dcf@… added

comment:3 Changed 6 years ago by nickm

Resolution: implemented
Status: needs_reviewclosed

Looks okay for me for now; I've merged it. Please open another ticket if you want to fix the "maybe we should create anotehr log notice" issue above.

Also next time, PLEASE make a changes file and mention the ticket number in the commit message.

Note: See TracTickets for help on using tickets.