Opened 7 years ago

Last modified 3 years ago

#7899 new defect

We forget to set tls_error sometimes

Reported by: asn Owned by:
Priority: Medium Milestone: Tor: unspecified
Component: Core Tor/Tor Version:
Severity: Normal Keywords: tor-client, tls, tor-control, sponsor8-maybe
Cc: Actual Points:
Parent ID: Points:
Reviewer: Sponsor:

Description

A weird guy in IRC mentioned that Tor forgets to set or_connection_t.tls_error sometimes.

He/she gave the call to flush_buf_tls() in connection_handle_write_impl() as an example of a situation that tls_error should be set but it's not.

Child Tickets

Change History (13)

comment:1 Changed 7 years ago by nickm

Keywords: controller added

Okay, it appears we use this to set the reasons for ORCONN close events that we send to the controller. Worth fixing, but not critical. I don't see another place that we use tls_error; please let me know if there is one.

comment:2 Changed 7 years ago by nickm

Milestone: Tor: 0.2.4.x-finalTor: 0.2.5.x-final

comment:3 Changed 6 years ago by nickm

Milestone: Tor: 0.2.5.x-finalTor: 0.2.6.x-final

comment:4 Changed 5 years ago by nickm

Keywords: 026-triaged-1 026-deferrabled added

comment:5 Changed 5 years ago by nickm

Milestone: Tor: 0.2.6.x-finalTor: 0.2.???

comment:6 Changed 3 years ago by teor

Milestone: Tor: 0.2.???Tor: 0.3.???

Milestone renamed

comment:7 Changed 3 years ago by nickm

Keywords: tor-03-unspecified-201612 added
Milestone: Tor: 0.3.???Tor: unspecified

Finally admitting that 0.3.??? was a euphemism for Tor: unspecified all along.

comment:8 Changed 3 years ago by nickm

Keywords: tor-03-unspecified-201612 removed

Remove an old triaging keyword.

comment:9 Changed 3 years ago by nickm

Keywords: 026-triaged-1 removed

comment:10 Changed 3 years ago by nickm

Keywords: 026-deferrabled removed
Severity: Normal

comment:11 Changed 3 years ago by dgoulet

Unify controller keyword to "tor-control".

comment:12 Changed 3 years ago by dgoulet

Keywords: tor-control added; controller removed

Unify "controller" keyword to "tor-control".

comment:13 Changed 3 years ago by nickm

Keywords: sponsor8-maybe added
Note: See TracTickets for help on using tickets.