Opened 11 years ago

Last modified 11 years ago

#796 closed defect (Fixed)

recently introduced compile error?

Reported by: yancm Owned by: nickm
Priority: High Milestone:
Component: Applications/Torbutton Version: 1.2.0rc5
Severity: Keywords:
Cc: yancm, nickm Actual Points:
Parent ID: Points:
Reviewer: Sponsor:

Description

For the last couple of days, I've been unable to compile tor on NetBSD 4_Stable.

Trying to compile svn v.16450 the compile crashes out on:
gcc -DHAVE_CONFIG_H -I. -I../.. -DSHARE_DATADIR="\"/usr/local/share\"" -DLOCALSTATEDIR="\"/usr/local/var\"" -DBINDIR="\"/usr/local/bin\"" -I/usr/local/include -I/usr/pkg/include -I/usr/X11R6/include -I../common -I/usr/pkg/include -g -O2 -Wall -g -O2 -MT connection_edge.o -MD -MP -MF .deps/connection_edge.Tpo -c -o connection_edge.o connection_edge.c
connection_edge.c: In function 'connection_ap_get_original_destination':
connection_edge.c:1730: error: aggregate value used where an integer was expected
connection_edge.c:1730: error: aggregate value used where an integer was expected
connection_edge.c:1730: error: aggregate value used where an integer was expected
connection_edge.c:1730: error: aggregate value used where an integer was expected
connection_edge.c:1730: error: aggregate value used where an integer was expected
connection_edge.c:1730: error: aggregate value used where an integer was expected
* Error code 1

I've run make clean and re-run autogen.sh without improvement.

[Automatically added by flyspray2trac: Operating System: All]

Child Tickets

Change History (9)

comment:1 Changed 11 years ago by nickm

Looks like I missed a spot when I was converting the code to handle ipv6 addresses internally. Will fix.

comment:2 Changed 11 years ago by nickm

I've checked in a possible fix. Could somebody on a BSD let me know if it works? There was a lot of code that needed to
change, and there might be a typo left somewhere.

comment:3 Changed 11 years ago by yancm

Tried latest svn v.16471

No joy yet...

Making all in or
gcc -DHAVE_CONFIG_H -I. -I../.. -DSHARE_DATADIR="\"/usr/local/share\"" -DLOCALSTATEDIR="\"/usr/local/var\"" -DBINDIR="\"/usr/local/bin\"" -I/usr/local/include -I/usr/pkg/include -I/usr/X11R6/include -I../common -I/usr/pkg/include -g -O2 -Wall -g -O2 -MT connection_edge.o -MD -MP -MF .deps/connection_edge.Tpo -c -o connection_edge.o connection_edge.c
connection_edge.c: In function 'connection_ap_get_original_destination':
connection_edge.c:1736: error: incompatible type for argument 1 of 'tor_addr_to_ipv4n'
connection_edge.c:1743: error: incompatible type for argument 1 of 'tor_addr_to_in6'
connection_edge.c:1746: warning: implicit declaration of function 'siszeof'
connection_edge.c:1746: error: expected expression before 'struct'
connection_edge.c:1763: error: invalid type argument of '->'
connection_edge.c:1764: warning: passing argument 2 of 'tor_addr_from_ipv4n' makes integer from pointer without a cast
connection_edge.c:1765: error: invalid type argument of '->'
connection_edge.c:1766: warning: passing argument 2 of 'tor_addr_from_ipv6_bytes' from incompatible pointer type
connection_edge.c:1772: warning: implicit declaration of function 'tor_addr_to_sring'
connection_edge.c:1717: warning: unused variable 'tmpbuf'
* Error code 1

Stop.
make: stopped in /home/yancm/torsrc/src/or

comment:4 Changed 11 years ago by nickm

Okay, any better now? (r16472)

comment:5 Changed 11 years ago by yancm

Well, some progress at v.16473, compiles with warnings, dies in linker.

Making all in or
gcc -DHAVE_CONFIG_H -I. -I../.. -DSHARE_DATADIR="\"/usr/local/share\"" -DLOCALSTATEDIR="\"/usr/local/var\"" -DBINDIR="\"/usr/local/bin\"" -I/usr/local/include -I/usr/pkg/include -I/usr/X11R6/include -I../common -I/usr/pkg/include -g -O2 -Wall -g -O2 -MT connection_edge.o -MD -MP -MF .deps/connection_edge.Tpo -c -o connection_edge.o connection_edge.c
connection_edge.c: In function 'connection_ap_get_original_destination':
connection_edge.c:1765: warning: pointer targets in passing argument 2 of 'tor_addr_from_ipv6_bytes' differ in signedness
connection_edge.c:1771: warning: implicit declaration of function 'tor_addr_to_string'

[...snip clean compiles...]

gcc -g -O2 -Wall -g -O2 -L/usr/pkg/lib -L/usr/pkg/lib -Wl,-R/usr/pkg/lib -o tor buffers.o circuitbuild.o circuitlist.o circuituse.o command.o config.o connection.o connection_edge.o connection_or.o control.o cpuworker.o directory.o dirserv.o dirvote.o dns.o dnsserv.o geoip.o hibernate.o main.o networkstatus.o onion.o policies.o reasons.o relay.o rendcommon.o rendclient.o rendmid.o rendservice.o rephist.o router.o routerlist.o routerparse.o eventdns.o tor_main.o ../common/libor.a ../common/libor-crypto.a -lz -levent -lssl -lcrypto -lpthread
connection_edge.o: In function `connection_ap_process_transparent':
/home/yancm/torsrc/src/or/connection_edge.c:1771: undefined reference to `tor_addr_to_string'
* Error code 1

comment:6 Changed 11 years ago by nickm

Closer and closer. Any better now? (r16474)

comment:7 Changed 11 years ago by yancm

Yes! At r16477 I have a clean compile, install and have updated.

I'm thinking you can close this out...

Thanks!

comment:8 Changed 11 years ago by nickm

You're welcome, and thanks for your patience!

comment:9 Changed 11 years ago by nickm

flyspray2trac: bug closed.

Note: See TracTickets for help on using tickets.