Opened 5 years ago

Closed 5 years ago

Last modified 5 years ago

#7969 closed enhancement (fixed)

Log whether flash proxies have opted in

Reported by: dcf Owned by: aallai
Priority: High Milestone:
Component: Archived/Flashproxy Version:
Severity: Keywords:
Cc: bastik.public@…, alexandre.allaire@… Actual Points:
Parent ID: Points:
Reviewer: Sponsor:

Description

Make the facilitator log, for each request, whether the proxy has set the flashproxy-allow cookie. This will allow us to estimate how much proxy capacity we will lose by going to opt-in-only.

Child Tickets

Attachments (3)

flashproxy-allow.png (7.8 KB) - added by dcf 5 years ago.
flashproxy-allow-frac.png (5.9 KB) - added by dcf 5 years ago.
flashproxy-allow.20130220.gz (1.6 MB) - added by dcf 5 years ago.
Log file of cookie settings.

Download all attachments as: .zip

Change History (11)

comment:1 Changed 5 years ago by bastik

Cc: bastik.public@… added

comment:2 Changed 5 years ago by dcf

It occurs to me that we could also just require opt-in for a few days and see what happens. Proxies reload themselves every 24 hours because of a meta refresh in the embed. Make the switch, give them 24 hours to settle, then a day or two of measuring capacity, then switch back.

comment:3 Changed 5 years ago by dcf

Owner: changed from dcf to aallai
Status: newassigned

comment:4 Changed 5 years ago by aallai

Cc: alexandre.allaire@… added
Status: assignedneeds_review

I have an implementation at https://github.com/aallai/flashproxy.git branch opt-in.The proxy sends the repr() of the cookie setting to facilitator.cgi, which then writes a timestamp and newline to the appropriate text file. 

According to http://pubs.opengroup.org/onlinepubs/009695399/functions/pwrite.html, we don't need to worry about file locking for appends, as long as we don't run into file size limits (i.e. disk gets full). 

comment:5 Changed 5 years ago by dcf

Status: needs_reviewneeds_information

I rebased and reworked your opt-in branch to this: https://gitweb.torproject.org/user/dcf/flashproxy.git/shortlog/refs/heads/allow-log.

This is running now on the public facilitator (as of 2013-02-05 19:13:28 EST) and we are logging cookie values. I'll wait a few days and update the ticket.

comment:6 Changed 5 years ago by dcf

Resolution: fixed
Status: needs_informationclosed

I showed graphs of the last two weeks of logs in my talk today. Thanks aallai for helping with the graphs. Also attaching the grpahs to the ticket.

http://bamsoftware.com/talks/ee380-flashproxy/index.html#s13
http://bamsoftware.com/talks/ee380-flashproxy/index.html#s14

It looks like about 2 or 3 percent of our current proxies have opted in. Marking this done because we got the logging done, now have to decide what to do with the results.

Changed 5 years ago by dcf

Attachment: flashproxy-allow.png added

Changed 5 years ago by dcf

Attachment: flashproxy-allow-frac.png added

comment:7 Changed 5 years ago by dcf

Actually I decided I don't want to keep the cookie logging forever. Let's turn it on again in the future if we need it. I pushed proxy code that doesn't send the cookie value at Thu Feb 21 13:04:51 PST 2013.

comment:8 Changed 5 years ago by dcf

Attaching the log file that was the data source for the attached graphs. Also present in http://bamsoftware.com/talks/ee380-flashproxy.zip.

Changed 5 years ago by dcf

Log file of cookie settings.

Note: See TracTickets for help on using tickets.