Opened 7 years ago

Closed 7 years ago

#7977 closed defect (implemented)

Have autoconf detect signed enum

Reported by: nickm Owned by:
Priority: Low Milestone: Tor: 0.2.4.x-final
Component: Core Tor/Tor Version:
Severity: Keywords: tor-client cleanup autoconf
Cc: Actual Points:
Parent ID: Points:
Reviewer: Sponsor:

Description

On MSVC, enums are always signed. With #7305, we made an ENUM_BF macro to avoid problems with signed enums. But that macro needs to know whether by default enum types are signed or not. It would be better to detect this with autoconf than just to check for defined(_MSC)

Child Tickets

Change History (3)

comment:1 Changed 7 years ago by nickm

Status: newneeds_review

Branch "signof_enum" in my public repo.

comment:2 Changed 7 years ago by andrea

Looks fine, merge it.

comment:3 Changed 7 years ago by nickm

Resolution: implemented
Status: needs_reviewclosed

Great; merged. Thanks!

Note: See TracTickets for help on using tickets.