Opened 7 years ago

Closed 7 years ago

Last modified 7 years ago

#7996 closed defect (fixed)

scapy-based test example code has wrong example

Reported by: arma Owned by: hellais
Priority: Medium Milestone:
Component: Archived/Ooni Version:
Severity: Keywords:
Cc: Actual Points:
Parent ID: Points:
Reviewer: Sponsor:

Description

On (I think it was) https://ooni.torproject.org/docs/writing_tests.html there is some sample code using twisted.defer.inlineCallbacks() which calls

optParameters = [['target', 't', self.localOptions['target'], "Specify the target to ping"]]

Arturo thought part of this line was wrong -- self.localOptions should either be 127.0.0.1 or None.

Child Tickets

Change History (2)

comment:1 Changed 7 years ago by hellais

Resolution: fixed
Status: newclosed

Thanks for reporting this!

Fixed: https://github.com/TheTorProject/ooni-probe/pull/31.

comment:2 Changed 7 years ago by ioerror

Seems reasonable. I've merged the fix.

Note: See TracTickets for help on using tickets.