Tor Client : "circuit_package_relay_cell(): Bug: outgoing relay cell has n_chan==NULL. Dropping"

[notice] Tor 0.2.4.9-alpha-dev (git-ee421e68d5231e39) opening new log file. ... [warn] circuit_package_relay_cell(): Bug: outgoing relay cell has n_chan==NULL. Dropping.

changed milestone to %Tor: 0.2.4.x-final

added MikePerry201301 component::core tor/tor milestone::Tor: 0.2.4.x-final owner::mikeperry priority::medium resolution::fixed status::closed tor-client type::defect version::tor 0.2.4.9-alpha labels

Is this a relay, or a client? (Tentatively classifying as tor-relay.)

Trac:
Component: - Select a component to Tor
Keywords: N/A deleted, tor-relay added
Milestone: N/A to Tor: 0.2.4.x-final

Trac:
Version: N/A to Tor: 0.2.4.9-alpha

Replying to nickm:

Is this a relay, or a client? (Tentatively classifying as tor-relay.)

It's a client ... I've explicitely set ClientOnly 1 in the torrc and tor is listening only to local standard ports ( sock port 9050, control port 9051 , transparent proxy port 9040 , dns port 5353 )

Trac:
Keywords: tor-relay deleted, tor-client added

I found an instance of this while testing #7802 (moved). It was caused by a path bias probe. I can add a check for circ->n_chan != NULL && (circ->n_chan->state == CHANNEL_STATE_OPEN || circ->n_chan->state == CHANNEL_STATE_MAINT) in pathbias_send_usable_probe(), unless there is a better fix.

Trac:
Owner: N/A to mikeperry
Keywords: N/A deleted, MikePerry201301 added
Status: new to assigned

I pushed this fix (modulo DeMorgan) to mikeperry/bug7802 and restarted my testing. The check has been exercised successfully a few times already. It might take me a while to trigger the null condition though. I guess maybe my Internet connection must have dropped?

Trac:
Status: assigned to needs_review

That's not the format for a changes file. Otherwise, looks plausible, but I'd ask andrea to have a look to make sure it looks okay to her.

Trac:
Cc: N/A to andrea

(Assuming that a78542f0c30a6d8a25b3a8 is the commit in question)

This looks fine to me; merging.

Merged.

Trac:
Resolution: N/A to fixed
Status: needs_review to closed

Gah, I fail merging forever. That picked up mikeperry's 7802 branch too.

off to do a quick review on that

Trac:
Resolution: fixed to N/A
Status: closed to reopened

We just did a little emergency post-merge review, and stuff looks basically okay. Closing this and #7802 (moved); Andrea is opening a new ticket with the issues we found during review.

Trac:
Resolution: N/A to fixed
Status: reopened to closed

closed

mentioned in issue #8185 (moved)

moved to tpo/core/tor#8024 (closed)