Opened 8 years ago

Closed 7 years ago

#8044 closed enhancement (fixed)

fix tls_handshake.py test to work with ooniprobe

Reported by: isis Owned by: isis
Priority: Medium Milestone:
Component: Archived/Ooni Version:
Severity: Keywords: ooni_tests
Cc: hellais, ioerror Actual Points:
Parent ID: Points:
Reviewer: Sponsor:

Description

This test was an anonymous contribution which is only called as a separate script. It needs to be ported to be an ooni nettest.

Child Tickets

Change History (3)

comment:1 Changed 8 years ago by isis

Status: newneeds_review

This is being worked on in my dev-tls-handshake branch, and is currently finished, although the unittests are not yet completed.

There is also a discussion of why doing TLS handshakes in pyOpenSSL is painful here. I am not sure yet that this is a problem, but it was originally why I had planned to use tlslite.

comment:2 Changed 8 years ago by isis

This was finished, and then refactored again as per #8353. The code is in my branch feature/tls-handshake-rebased here: https://github.com/isislovecruft/ooni-probe/blob/feature/tls-handshake-rebased/nettests/experimental/tls_handshake.py

It needs review before merging.

comment:3 Changed 7 years ago by isis

Resolution: fixed
Status: needs_reviewclosed

merged to master in 875dc22d85d8391b81f6fe988f080a2cb41d65e3

Note: See TracTickets for help on using tickets.