Opened 6 years ago

Closed 6 years ago

#8045 closed defect (implemented)

torspec: Make public bridges add obfsproxy stats to their extra-info descriptors

Reported by: asn Owned by:
Priority: Medium Milestone: Tor: 0.2.5.x-final
Component: Core Tor/Tor Version:
Severity: Keywords: pt tor-spec tor-bridge
Cc: karsten Actual Points:
Parent ID: #5040 Points:
Reviewer: Sponsor:

Description

This ticket is for specifying the bridge-transport extra-info descriptor directive, as introduced by:
https://trac.torproject.org/projects/tor/ticket/5040#comment:2

Child Tickets

Change History (12)

comment:1 Changed 6 years ago by asn

Status: newneeds_review

Please see branch bug8045 in https://git.torproject.org/user/asn/torspec.git.

FWIW, I changed the suggested name from bridge-transport to bridge-transports.

comment:2 Changed 6 years ago by asn

The special identifier "<OR>" was selected because pluggable transport names must be C identifiers.

comment:3 Changed 6 years ago by karsten

Maybe call the keyword bridge-ip-transports similar to bridge-ip-versions to indicate that we're counting unique IP addresses here. Do you really mean <OR> or just OR? Can you specify in dir-spec.txt what are valid characters for pluggable transport names, e.g., [A-Za-z0-9-]*?

comment:4 in reply to:  3 Changed 6 years ago by asn

Replying to karsten:

Maybe call the keyword bridge-ip-transports similar to bridge-ip-versions to indicate that we're counting unique IP addresses here. Do you really mean <OR> or just OR? Can you specify in dir-spec.txt what are valid characters for pluggable transport names, e.g., [A-Za-z0-9-]*?

Yep, good idea. Pushed a new commit to the branch. How does it look now?

(I actually meant <OR>, not OR.)

comment:5 Changed 6 years ago by asn

Because of the large number of fixup commits in bug8045, please see branch bug8045_take2 in https://git.torproject.org/user/asn/torspec.git.

comment:6 in reply to:  5 Changed 6 years ago by karsten

Replying to asn:

Because of the large number of fixup commits in bug8045, please see branch bug8045_take2 in https://git.torproject.org/user/asn/torspec.git.

Looks good to me.

comment:7 Changed 6 years ago by asn

What about bug8045_take3? Do you like the idea?

The idea is that if the transport proxy supports the Extended ORPort but does not support the TRANSPORT command, Tor should list the connection as unidentified transport. Otherwise, it would list it as <OR> which would have been inaccurate.

comment:8 Changed 6 years ago by nickm

Milestone: Tor: 0.2.5.x-final

comment:9 in reply to:  7 Changed 6 years ago by karsten

Replying to asn:

What about bug8045_take3? Do you like the idea?

The idea is that if the transport proxy supports the Extended ORPort but does not support the TRANSPORT command, Tor should list the connection as unidentified transport. Otherwise, it would list it as <OR> which would have been inaccurate.

Sounds reasonable.

comment:10 Changed 6 years ago by nickm

Keywords: tor-spec added; torspec removed

Bulk-replacing "spec" and "torspec" keywords with "tor-spec".

comment:11 Changed 6 years ago by nickm

Keywords: tor-bridge added

comment:12 Changed 6 years ago by nickm

Resolution: implemented
Status: needs_reviewclosed

Squashed and merged!

Note: See TracTickets for help on using tickets.