torspec: Make public bridges add obfsproxy stats to their extra-info descriptors

This ticket is for specifying the bridge-transport extra-info descriptor directive, as introduced by: https://trac.torproject.org/projects/tor/ticket/5040#comment:2

changed milestone to %Tor: 0.2.5.x-final

added component::core tor/tor milestone::Tor: 0.2.5.x-final parent::5040 priority::medium pt resolution::implemented status::closed tor-bridge tor-spec type::defect labels

Please see branch bug8045 in https://git.torproject.org/user/asn/torspec.git.

FWIW, I changed the suggested name from bridge-transport to bridge-transports.

Trac:
Status: new to needs_review

The special identifier "<OR>" was selected because pluggable transport names must be C identifiers.

Maybe call the keyword bridge-ip-transports similar to bridge-ip-versions to indicate that we're counting unique IP addresses here. Do you really mean <OR> or just OR? Can you specify in dir-spec.txt what are valid characters for pluggable transport names, e.g., [A-Za-z0-9-]*?

Replying to karsten:

Maybe call the keyword bridge-ip-transports similar to bridge-ip-versions to indicate that we're counting unique IP addresses here. Do you really mean <OR> or just OR? Can you specify in dir-spec.txt what are valid characters for pluggable transport names, e.g., [A-Za-z0-9-]*?

Yep, good idea. Pushed a new commit to the branch. How does it look now?

(I actually meant <OR>, not OR.)

Because of the large number of fixup commits in bug8045, please see branch bug8045_take2 in https://git.torproject.org/user/asn/torspec.git.

Replying to asn:

Because of the large number of fixup commits in bug8045, please see branch bug8045_take2 in https://git.torproject.org/user/asn/torspec.git.

Looks good to me.

What about bug8045_take3? Do you like the idea?

The idea is that if the transport proxy supports the Extended ORPort but does not support the TRANSPORT command, Tor should list the connection as unidentified transport. Otherwise, it would list it as <OR> which would have been inaccurate.

Trac:
Milestone: N/A to Tor: 0.2.5.x-final

Replying to asn:

What about bug8045_take3? Do you like the idea?

The idea is that if the transport proxy supports the Extended ORPort but does not support the TRANSPORT command, Tor should list the connection as unidentified transport. Otherwise, it would list it as <OR> which would have been inaccurate.

Sounds reasonable.

Bulk-replacing "spec" and "torspec" keywords with "tor-spec".

Trac:
Keywords: torspec pt deleted, pt tor-spec added

Trac:
Keywords: pt tor-spec deleted, pt tor-spec tor-bridge added

Squashed and merged!

Trac:
Status: needs_review to closed
Resolution: N/A to implemented

closed

moved to tpo/core/tor#8045 (closed)