Opened 11 years ago

Last modified 7 years ago

#807 closed defect (Fixed)

Stream status events for reverse resolve requests

Reported by: mwenge Owned by: nickm
Priority: Low Milestone:
Component: Core Tor/Tor Version: 0.2.1.4-alpha
Severity: Keywords:
Cc: mwenge, nickm Actual Points:
Parent ID: Points:
Reviewer: Sponsor:

Description

(http://archives.seul.org/or/dev/Jul-2008/msg00017.html)

Stream status events for reverse resolve requests for which Tor has a cached
answer look like this:

650 STREAM 6 NEWRESOLVE 0 64.4.33.7:0
650 STREAM 6 FAILED 0 REVERSE[64.4.33.7]:0
650 STREAM 7 NEWRESOLVE 0 64.4.33.7:0
650 STREAM 7 FAILED 0 REVERSE[64.4.33.7]:0

The stream 'fails' because there is never a need to create it. The spec is a bit
unclear on this point but I think all streams deserve a CLOSE event. Or
is 'FAILED' considered sufficient?

I can allow a CLOSE event by doing:

Index: src/or/connection_edge.c
===================================================================
--- src/or/connection_edge.c (revision 15824)
+++ src/or/connection_edge.c (working copy)
@@ -1369,8 +1369,7 @@

map_expires);

connection_mark_unattached_ap(conn,

END_STREAM_REASON_DONE |

  • END_STREAM_REASON_FLAG_ALREADY_SOCKS_REPLIED |
  • END_STREAM_REASON_FLAG_ALREADY_SENT_CLOSED);

+ END_STREAM_REASON_FLAG_ALREADY_SOCKS_REPLIED);

return 0;

}
if (options->ClientDNSRejectInternalAddresses) {

but maybe it's the spec that needs to be clarified. A short note stating which
events should be expected for all streams maybe.

See also:

http://archives.seul.org/or/dev/Jul-2008/msg00033.html

[Automatically added by flyspray2trac: Operating System: All]

Child Tickets

Change History (3)

comment:1 Changed 11 years ago by nickm

Applied; thanks!

comment:2 Changed 11 years ago by nickm

flyspray2trac: bug closed.

comment:3 Changed 7 years ago by nickm

Component: Tor ClientTor
Note: See TracTickets for help on using tickets.