Opened 6 years ago

Closed 6 years ago

#8122 closed defect (implemented)

ntor is not documented in tor-spec.txt, dir-spec.txt

Reported by: rransom Owned by: nickm
Priority: Medium Milestone: Tor: 0.2.4.x-final
Component: Core Tor/Tor Version:
Severity: Keywords: tor-spec
Cc: Actual Points:
Parent ID: Points:
Reviewer: Sponsor:

Description


Child Tickets

Change History (9)

comment:1 Changed 6 years ago by nickm

Keywords: tor-spec added; spec removed

Bulk-replacing "spec" and "torspec" keywords with "tor-spec".

comment:2 Changed 6 years ago by nickm

Milestone: Tor: 0.2.4.x-final

comment:3 Changed 6 years ago by nickm

Owner: set to nickm
Status: newaccepted
Summary: ntor is not documented in tor-spec.txtntor is not documented in tor-spec.txt, dir-spec.txt

comment:4 Changed 6 years ago by nickm

Status: acceptedneeds_review

Please somebody skim branch "document-ntor" in my public torspec repository.

comment:5 Changed 6 years ago by rransom

Did you really use the same command number for both CREATE2 and CREATED2?

comment:6 Changed 6 years ago by rransom

Status: needs_reviewneeds_revision
+   In general, clients SHOULD use CREATE whenever they are using the TAP
+   handshake, and CREATED2 otherwise.  Clients SHOULD NOT send the

s/CREATED2/CREATE2/

+   Servers always replay to a successful reply CREATE with a CREATED,

s/reply //
s/replay/reply/

comment:7 Changed 6 years ago by rransom

+   When used in the ntor handshake, the first HASH_LEN form the forward

s/HASH_LEN/& bytes/

comment:8 Changed 6 years ago by nickm

Status: needs_revisionneeds_review

Thanks for the review, rransom!

Did you really use the same command number for both CREATE2 and CREATED2?

Ha; that would be some tricky engineering if I had! In fact, I just copy-and-pasted a number wrongly.

This and the other fixes above are now in branch "more-specs." Thanks!

comment:9 Changed 6 years ago by nickm

Resolution: implemented
Status: needs_reviewclosed

Merged; thanks!

Note: See TracTickets for help on using tickets.