Opened 7 years ago

Closed 7 years ago

#8146 closed defect (fixed)

Don't count Sybil relays when computing Fast, Guard, etc thresholds.

Reported by: arma Owned by:
Priority: Medium Milestone: Tor: 0.2.4.x-final
Component: Core Tor/Tor Version:
Severity: Keywords: tor-auth
Cc: Actual Points:
Parent ID: Points:
Reviewer: Sponsor:

Description

If you run ten relays on a single IP address (like is happening right now -- see also #8145), the directory authorities will only pick two of them for the consensus.

Problem is, the authority will use the stats from all ten of them when deciding the median bandwidth (used for the Guard flag), the 7/8th bandwidth (used for Fast flag), etc.

We should throw out the Sybils before calculating these thresholds.

Child Tickets

Change History (4)

comment:1 Changed 7 years ago by arma

Status: newneeds_review

arma/bug8146-scratch has some code that might do something. If it is correct (and it may well not be), it will want some refactoring too.

comment:2 Changed 7 years ago by nickm

I don't think that the digestmap_set() calls are right; don't you want digestmap_get() ? digestmap_set() changes omit_as_sybil, such that by the end of the loop, every router will have its identity in omit_as_sybil.

comment:3 Changed 7 years ago by nickm

Possibly better fix as 40c13240c08349b94d39a1af320f61a1f7a4fda0 in my omnibus branch "bug8146_etc". (I'm doing this as one branch since this is likely to all touch some of the same code.)

comment:4 Changed 7 years ago by nickm

Resolution: fixed
Status: needs_reviewclosed

ok; merging.

Note: See TracTickets for help on using tickets.