Opened 7 years ago

Closed 7 years ago

#8147 closed defect (implemented)

Guard, Stable, and HSDir flags don't get reset for Sybil relays

Reported by: arma Owned by:
Priority: Medium Milestone: Tor: 0.2.4.x-final
Component: Core Tor/Tor Version:
Severity: Keywords: tor-auth
Cc: Actual Points:
Parent ID: Points:
Reviewer: Sponsor:

Description

If you run ten relays on a single IP address (like is happening right now -- see also #8145), the directory authorities will only pick two of them for the consensus.

Problem is, the authority will track uptime for all ten of them, which influences whether they get the Guard, Stable, or HSDir flag when they come back into the consensus.

We should mark a Sybil as a 'downtime' event when we decide it doesn't deserve the Running flag.

Child Tickets

Change History (4)

comment:1 Changed 7 years ago by arma

Status: new → needs_review

branch bug8147 in my arma

comment:2 Changed 7 years ago by arma

Summary: Guard, Stable, and Fast flags don't get reset for Sybil relays → Guard, Stable, and HSDir flags don't get reset for Sybil relays

comment:3 Changed 7 years ago by nickm

I don't think that's right; it should happen right after making the sybil list, not while building our vote. Also, it should count as a little different than being down -- it should count as being very, very down.

I have an alternative patch as 4eff8b65305248b1e7a57d1efdf8f55039719bd7 in my "bug8146_etc" branch. Please review?

comment:4 Changed 7 years ago by nickm

Resolution: → implemented
Status: needs_review → closed

arma likes. merging.

Note: See TracTickets for help on using tickets.