Opened 7 years ago

Closed 7 years ago

#8158 closed defect (fixed)

Why are some m lines in the vote distinct?

Reported by: arma Owned by:
Priority: Low Milestone: Tor: 0.2.4.x-final
Component: Core Tor/Tor Version:
Severity: Keywords: tor-auth
Cc: Actual Points:
Parent ID: Points:
Reviewer: Sponsor:

Description

r default AtiM2Gi/NR32NgTlRFQhX+iS5gg tiSHrzH+PL0qkvkEYLdV7RCl4rU 2013-02-04 17:00:26 88.141.15.112 443 9030
s V2Dir Valid
v Tor 0.2.3.22-rc
w Bandwidth=33 Measured=31
p reject 25,119,135-139,445,563,1214,4661-4666,6346-6429,6699,6881-6999
m 16 sha256=7nf5UN7Nl2riqqaO6bNV/AZbfHQORIcTf5i5CB2xDTU
m 15 sha256=7nf5UN7Nl2riqqaO6bNV/AZbfHQORIcTf5i5CB2xDTU
m 14 sha256=7nf5UN7Nl2riqqaO6bNV/AZbfHQORIcTf5i5CB2xDTU
m 8,9,10,11,12,13 sha256=7nf5UN7Nl2riqqaO6bNV/AZbfHQORIcTf5i5CB2xDTU

Why does that last line not just have 14,15,16 on it too?

Child Tickets

Change History (10)

comment:1 Changed 7 years ago by nickm

It could; the issue is that methods 14, 15, and 16 do specify different stuff that could go in microdescriptors. In this case, it turned out that they were the same, but we didn't actually know that in advance. Let's see if there's an easy tweak...

comment:2 Changed 7 years ago by nickm

Milestone: Tor: 0.2.4.x-finalTor: 0.2.5.x-final

Actually, I'm a bit inclined to defer this to 0.2.5.x. It isn't hurting anything besides making votes a little bigger, and post-compression it's not making them much bigger at all.

It's okay to move this back to 0.2.4.x if there's something I'm missing.

comment:3 Changed 7 years ago by arma

Priority: normalminor

comment:4 Changed 7 years ago by nickm

Milestone: Tor: 0.2.5.x-finalTor: 0.2.4.x-final

Actually, this is pretty simple, and might free some space pressure. See branch "bug8158" in my public repository.

comment:5 Changed 7 years ago by nickm

Status: newneeds_review

(This branch needs testing!)

comment:6 Changed 7 years ago by arma

I looked at the general structure of the patch, and it looks fine. I didn't check the pointer arithmetic.

Shall I try running it on moria1? It should be backward-compatible yes?

comment:7 in reply to:  6 Changed 7 years ago by nickm

Replying to arma:

I looked at the general structure of the patch, and it looks fine. I didn't check the pointer arithmetic.

Shall I try running it on moria1? It should be backward-compatible yes?

It should be! Look closely at the output, make sure that nothing is omitted, and remember how many of the pieces you get to keep if it breaks. :)

comment:8 Changed 7 years ago by arma

http://freehaven.net/~arma/moria1-v3-status-votes from moria1 now shows lines like

m 8,9,10,11,12,13,14,15,16 sha256=a8nH9eVP1RIdU1fOTQsDHtv1GjiE/ffd7q/s+cXcxZc

I think that means it's working.

comment:9 Changed 7 years ago by nickm

And it also shows lines like

m 8,9,10,11,12,13,14,15 sha256=HHkK6HWjo8c4ljDatw4phcfqynlP5cvwLbovM5eEjE4
m 16 sha256=kP3Dh6QmapyTKymahH0wFIHuTlW5ikSA5eL/eLky3x8

which confirms that it isn't just blindly coalescing.

I think this means it's mergeable.

comment:10 Changed 7 years ago by nickm

Resolution: fixed
Status: needs_reviewclosed

And, merged.

Note: See TracTickets for help on using tickets.