Opened 6 years ago

Last modified 17 months ago

#8160 new enhancement

Create separate pending counters during circuit construction

Reported by: mikeperry Owned by: mikeperry
Priority: Medium Milestone: Tor: unspecified
Component: Core Tor/Tor Version:
Severity: Normal Keywords: tor-client pathbias cleanup refactor
Cc: Actual Points:
Parent ID: Points:
Reviewer: Sponsor:

Description

While testing the path bias code, I noticed a source of rounding error when we scaled our counts down while circuits are open. I corrected for this by counting the number of open circuits during scaling and subtracting that from our counts where appropriate, but a better fix might be to actually store separate pending counters that we don't transfer into the official, scaled counters until circuit closure.

Child Tickets

Change History (5)

comment:1 Changed 5 years ago by nickm

Milestone: Tor: 0.2.5.x-finalTor: 0.2.???

comment:2 Changed 2 years ago by teor

Milestone: Tor: 0.2.???Tor: 0.3.???

Milestone renamed

comment:3 Changed 22 months ago by nickm

Keywords: tor-03-unspecified-201612 added
Milestone: Tor: 0.3.???Tor: unspecified

Finally admitting that 0.3.??? was a euphemism for Tor: unspecified all along.

comment:4 Changed 17 months ago by nickm

Keywords: tor-03-unspecified-201612 removed

Remove an old triaging keyword.

comment:5 Changed 17 months ago by nickm

Keywords: pathbias cleanup refactor added
Severity: Normal

mike, can you say more about the impact here and give an example of the fix you have in mind? This sounds like a cleanup that would improve clarity.

Note: See TracTickets for help on using tickets.