Opened 7 years ago

Closed 5 years ago

#8197 closed defect (fixed)

Do something about policies_parse_exit_policy()'s arguments

Reported by: arma Owned by: rl1987
Priority: Medium Milestone: Tor: 0.2.6.x-final
Component: Core Tor/Tor Version:
Severity: Keywords: tor-client easy refactor
Cc: Actual Points:
Parent ID: Points:
Reviewer: Sponsor:

Description

  r = policies_parse_exit_policy(&line, &policy, 1, 0, 0, 1);
...
  test_assert(0 == policies_parse_exit_policy(NULL, &policy2, 1, 1, 0, 1));

Quick quiz: which of these booleans means what? And which one isn't a boolean at all? :)

(Don't work on this ticket until we merge #5528.)

Child Tickets

Attachments (1)

0001-Verbosely-call-policies_parse_exit_policy.patch (3.5 KB) - added by merge 5 years ago.
Quick dirty fix by just naming parameters in the test

Download all attachments as: .zip

Change History (9)

comment:1 Changed 7 years ago by nickm

Keywords: tor-client added

comment:2 Changed 6 years ago by nickm

Keywords: easy refactor added

comment:3 Changed 6 years ago by nickm

Milestone: Tor: 0.2.5.x-finalTor: 0.2.???

Changed 5 years ago by merge

Quick dirty fix by just naming parameters in the test

comment:4 Changed 5 years ago by merge

Status: newneeds_review

comment:5 Changed 5 years ago by rl1987

Owner: set to rl1987
Status: needs_reviewaccepted

comment:6 Changed 5 years ago by rl1987

Status: acceptedneeds_review

comment:7 Changed 5 years ago by nickm

Milestone: Tor: 0.2.???Tor: 0.2.6.x-final

comment:8 Changed 5 years ago by nickm

Resolution: fixed
Status: needs_reviewclosed

Squashed and merged to master; thanks!

Note: See TracTickets for help on using tickets.