Opened 6 years ago

Last modified 18 months ago

#8278 new enhancement

Wrap conditionally-compiled C files in #ifdefs

Reported by: nickm Owned by:
Priority: Medium Milestone: Tor: unspecified
Component: Core Tor/Tor Version:
Severity: Normal Keywords: tor-relay, easy, style, compilation, build
Cc: Actual Points:
Parent ID: Points: small
Reviewer: Sponsor:

Description

For people editing Tor with an IDE, it can be helpful to have the files which won't get built surrounded with appropriate #ifdef blocks. That way, their IDE won't complain that the file is uncompileable when in fact it's not even supposed to get built.

This is also an issue for people writing their own build scripts/tools for Tor and getting it wrong, but I'm less interested in handling that case.

This ticket is more or less in "Lorax" status. ("Unless someone like you cares a whole awful lot / nothing is going to get better. It's not.") I'll take a clean patch for it in 0.2.5 or later if somebody writes one.

Child Tickets

Change History (9)

comment:1 Changed 4 years ago by nickm

Milestone: Tor: unspecifiedTor: 0.2.8.x-final

comment:2 Changed 4 years ago by nickm

Points: small

comment:3 Changed 3 years ago by nickm

Keywords: lorax added
Milestone: Tor: 0.2.8.x-finalTor: 0.2.???
Severity: Normal

comment:4 Changed 3 years ago by teor

Milestone: Tor: 0.2.???Tor: 0.3.???

Milestone renamed

comment:5 Changed 2 years ago by nickm

Keywords: tor-03-unspecified-201612 added
Milestone: Tor: 0.3.???Tor: unspecified

Finally admitting that 0.3.??? was a euphemism for Tor: unspecified all along.

comment:6 Changed 2 years ago by nickm

Keywords: tor-03-unspecified-201612 removed

Remove an old triaging keyword.

comment:7 Changed 2 years ago by nickm

Keywords: easy style compilation build added; lorax removed

comment:8 Changed 18 months ago by aruna1234

I understand the ticket, but how do we figure out which are the files which don't get compiled to be put under #ifdef blocks?

comment:9 Changed 18 months ago by teor

Read the include.am files on each directory to see which files get left out under particular conditions, and then add those conditions to the files themselves.

Note: See TracTickets for help on using tickets.