Opened 6 years ago

Closed 6 years ago

#8290 closed defect (fixed)

drop /etc/tor/tor-tsocks.conf

Reported by: proper Owned by:
Priority: Medium Milestone: Tor: 0.2.4.x-final
Component: Core Tor/Tor Version:
Severity: Keywords: tor-client
Cc: griffinboyce@… Actual Points:
Parent ID: Points:
Reviewer: Sponsor:

Description

/etc/tor/tor-tsocks.conf - is the really still necessary?

Please remove it.

Child Tickets

Change History (10)

comment:1 Changed 6 years ago by arma

Isn't it? Doesn't torsocks need some sort of config file to point tsocks at?

Or are you suggesting that we fold those defaults into torsocks, so it will work fine without a config file?

Or wait, this a Tor ticket -- are you suggesting that we should modify the Tor deb, since the torsocks deb has a different config file?

Lots of options here. Which ticket is this?

comment:2 in reply to:  1 Changed 6 years ago by proper

Replying to arma:

Isn't it?

It's still inside the Tor Debian package.

Doesn't torsocks need some sort of config file to point tsocks at?

I don't know that. I am only pointing out, that it seems redundant to me to have /etc/torsocks.conf (which really exists at time of writing after installing the torsocks Debian package) and also having a /etc/tor/tor-tsocks.conf.

Or are you suggesting that we fold those defaults into torsocks, so it will work fine without a config file?

If that is necessary, yes. torsocks configures these values in it's own configuration file /etc/torsocks.conf already anyway.

Or wait, this a Tor ticket -- are you suggesting that we should modify the Tor deb, since the torsocks deb has a different config file?

Yes.

Lots of options here. Which ticket is this?

Well, I am sorry, I don't know that for sure. I just don't see why it needs two configuration files if the first configuration file already contains all that is required. By the way the /etc/tor/tor-tsocks.conf has never had any effect for me anyway. All that torsocks does, is defined in /etc/torsocks.conf.

comment:3 Changed 6 years ago by sysrqb

arma, proper, this ticket is correct as-is. Tor distributes a file named tor-tsocks.conf in contrib/. It hasn't been touched since 2005. At this point, with the existance of torsocks and the config file it distributes this tor-tsocks.conf file is redundant and may possibly be confusing to end users. I agree that it should be banished unless there are others who have a good reason for keeping it.

comment:4 Changed 6 years ago by nickm

Milestone: Tor: 0.2.5.x-finalTor: 0.2.4.x-final

Removing an unused configuration file for another program could be in-scope for Tor 0.2.4.x. Let's do a quick spot-check to see if we have any instructions for using this, and if so whether we should switch them to be instructions to do something else, then remove this.

The patch is simple enough; it'll be one of those where the changes message is longer than the actual change.

comment:5 Changed 6 years ago by nickm

Keywords: tor-client added

comment:6 Changed 6 years ago by nickm

Status: newneeds_review

I sent an email to tor-talk (https://lists.torproject.org/pipermail/tor-talk/2013-February/027517.html) soliciting feedback if anybody's using this, and have added a branch "bug8290" to make the requisite changes. It also removes references to tsocks from our manual pages.

comment:7 Changed 6 years ago by saint

FWIW, I've yet to see a script or program use this etc/tor/torsocks.conf

It seems feasible to only have one file for this task.

comment:8 Changed 6 years ago by saint

Cc: griffinboyce@… added

comment:9 Changed 6 years ago by arma

Dropping it from Tor's contrib/ sounds good to me. We'll also want to drop it from our tarball (of course). And we'll want to notify the packagers that it isn't in the tarball anymore, since the deb build script (for example) will break.

comment:10 Changed 6 years ago by nickm

Resolution: fixed
Status: needs_reviewclosed

Merged!

Note: See TracTickets for help on using tickets.