Opened 5 years ago

Closed 5 years ago

#8300 closed defect (fixed)

Adblock Plus + Easylist in Chrome blocks Flashproxy

Reported by: legind Owned by: dcf
Priority: Medium Milestone:
Component: Archived/Flashproxy Version:
Severity: Keywords:
Cc: arlolra@… Actual Points:
Parent ID: Points:
Reviewer: Sponsor:

Description

Probably not a problem on the Flashproxy end, but it seems that Chrome + Adblock Plus *without any filters enabled* is blocking the flashproxy badge from loading. Interestingly, the same problem does not appear for Adblock Plus on Firefox.

Tested with [Chrome 24.0.1312.70, Adblock Plus 1.3.4] and [Chromium 24.0.1312.56 Ubuntu 12.10, Adblock Plus 1.3.4]

Child Tickets

Attachments (1)

0001-ensure-lastChild-is-document.body.patch (784 bytes) - added by arlolra 5 years ago.

Download all attachments as: .zip

Change History (6)

Changed 5 years ago by arlolra

comment:1 Changed 5 years ago by arlolra

Cc: arlolra@… added

The attached patch should fix this bug. What's happening, as far as I can tell, is that adblock is adding an empty style tag underneath the body of each page. This makes it the lastChild in document, pushing the badge below it, hiding it from the visible area of the embed tag.

comment:2 in reply to:  1 Changed 5 years ago by dcf

Replying to arlolra:

The attached patch should fix this bug. What's happening, as far as I can tell, is that adblock is adding an empty style tag underneath the body of each page. This makes it the lastChild in document, pushing the badge below it, hiding it from the visible area of the embed tag.

Thanks for the patch. Does it also work to just do

    e = document.body;

Without the patch, does the proxy still run even though invisible, or does it not run at all? You should get debugging messages in the console if it is running and you set the debug query string parameter.

comment:3 Changed 5 years ago by arlolra

Does it also work to just do e = document.body;

Yes, it does (cleaner too). I just wanted to be explicit about document's lastChild needing to be document.body

Without the patch, does the proxy still run even though invisible, or does it not run at all?

It seems to run; the badge just isn't visible.

comment:4 Changed 5 years ago by arlolra

Status: newneeds_review

comment:5 Changed 5 years ago by dcf

Resolution: fixed
Status: needs_reviewclosed

Thanks, merged.

Note: See TracTickets for help on using tickets.