Opened 6 years ago

Closed 6 years ago

#8301 closed enhancement (fixed)

Remove the Torbutton Display Settings Panel

Reported by: mikeperry Owned by: mikeperry
Priority: High Milestone:
Component: TorBrowserButton Version:
Severity: Keywords: tbb-usability
Cc: Actual Points:
Parent ID: Points:
Reviewer: Sponsor:

Description

The Torbutton Display Options panel is pretty useless. We should just kill it.

Child Tickets

Attachments (1)

8301.patch (109.0 KB) - added by sukhbir 6 years ago.
patch for 8301

Download all attachments as: .zip

Change History (5)

comment:1 Changed 6 years ago by mikeperry

Keywords: tbb-usability added

Changed 6 years ago by sukhbir

Attachment: 8301.patch added

patch for 8301

comment:2 Changed 6 years ago by sukhbir

Patch attached. I think removing the `locale' lines was an overkill because it increases the size of the patch, but I decided to put it in anyways.

comment:3 Changed 6 years ago by mikeperry

Keywords: MikePerry201304 added
Status: newneeds_review

sukbir: Please set needs review and my monthly tag on stuff, especially if you think it's simple and quicky mergeable.

However, this patch is not yet immediately mergable because it touches non-English locale data. This time, I can just rip this part out. Next time, only remove the English strings. The tx tools should handle the update for translators (but obviously a watchful eye on that process would be appreciated, if it's not too much trouble).

comment:4 Changed 6 years ago by mikeperry

Keywords: MikePerry201304 removed
Resolution: fixed
Status: needs_reviewclosed

Merged, and present in Torbutton 1.5.2.

Note: See TracTickets for help on using tickets.