Opened 7 years ago

Closed 2 years ago

#8328 closed defect (fixed)

compass lists first 10 but says it defaults to all

Reported by: arma Owned by: gsathya
Priority: Medium Milestone:
Component: Metrics/Compass Version:
Severity: Normal Keywords:
Cc: Actual Points:
Parent ID: Points:
Reviewer: Sponsor:

Description

On compass.torproject.org in 'number of results' it defaults to -1, but actually it seems to default to 10. When I change -1 to 100, I get 100. But when I leave it -1, I get 10.

We should either make it obey the -1, or change the -1 to 10 to match what it does.

Child Tickets

Change History (8)

comment:1 Changed 7 years ago by mo

If you put in -1, it does list all. The greyed out -1 that is there is just an example. I would say change it to 10, and done.

comment:2 Changed 7 years ago by arma

Sounds good to me. I just want the (apparent) defaults to be what I get by default. :)

comment:3 Changed 7 years ago by karsten

gsathya, if you write a patch, I can merge and deploy it.

comment:4 Changed 7 years ago by gsathya

Status: newaccepted

The first time you press "submit" without mentioning any value for the "number of relays", compass shows 10 relays. Now change the value to "-1" and press "submit", and you get all the relays. Next remove the "-1" and leave "number of relays" empty(like we did initially) but now compass returns all the relays. So is "-1" or "10" the default? This is broken behavior.

Fixing..

comment:5 Changed 7 years ago by gsathya

Status: acceptedneeds_review

I went into a rabbit hole and started refactoring compass here - https://github.com/gsathya/compass/compare/refactor2 and it's still not done :/

As a temp fix - I've pushed the changes that mo suggested here - https://github.com/gsathya/compass/compare/bug_8328

comment:6 in reply to:  5 Changed 7 years ago by karsten

Replying to gsathya:

As a temp fix - I've pushed the changes that mo suggested here - https://github.com/gsathya/compass/compare/bug_8328

Merged and deployed.

comment:8 Changed 2 years ago by karsten

Resolution: fixed
Severity: Normal
Status: needs_reviewclosed

I believe this is fixed. Either that, or I don't understand the issue. Closing as fixed.

Note: See TracTickets for help on using tickets.