Opened 7 years ago

Closed 6 years ago

#8331 closed defect (fixed)

ooni: string formatting error in runner.runTestCasesWithInputUnit()

Reported by: isis Owned by: isis
Priority: Medium Milestone:
Component: Archived/Ooni Version:
Severity: Keywords: ooni, bugreport
Cc: hellais, ioerror, aagbsn, isis Actual Points:
Parent ID: Points:
Reviewer: Sponsor:

Description

This surfaced in debugging #8329:

Traceback (also attached):

(ooni)isis@wintermute:~/code/torproject/ooni-probe$ s ./bin/ooniprobe nettests/experimental/tls_handshake.py -f ./private/lists/bridgelist.fake
[sudo] password for isis:
[!] pypcap or dnet not installed. Certain tests may not work.
Log opened.
Starting
Starting sniffer
[!] Initializing DummyPcapWriter. We will not actually write to a pcapfile
[D] No test deck detected
[D] processing options
[D] Running [(<class 'nettests.experimental.tls_handshake.TLSHandshakeTest'>, 'test_tlsv1_handshake')]
[D] Options {'inputs': <ooni.nettest.inputProcessorIterator object at 0x2de3590>, 'version': '0.0.1', 'name': 'tls-handshake'}
[D] cmd_line_options {'pcapfile': None, 'help': 0, 'subargs': ('-f', './private/lists/bridgelist.fake'), 'resume': 0, 'parallelism': '10', 'test': 'nettests/ex
perimental/tls_handshake.py', 'logfile': None, 'collector': None, 'reportfile': None}
[D] Creating report_tls_handshake_2013-02-24T215533Z.yamloo
[D] Writing report with YAML reporter
Reporting to file report_tls_handshake_2013-02-24T215533Z.yamloo
[D] Not going to resume tls_handshake.py
[D] input_unit_items: 1
[D] test_case_number: 1.0
[D] Test case number: 1.0
[D] Total iterations: 1.0
[D] Current iteration: 0.0
[D] Running tls_handshake.py with input unit <<class 'ooni.inputunit.InputUnit'> inputs=<listiterator object at 0x2de3850>>
[D] Running test cases with input unit
Traceback (most recent call last):
  File "/home/isis/code/torproject/ooni-probe/ooni/runner.py", line 462, in runTestCases
    yaml_reporter, oonib_reporter)
  File "/home/isis/code/torproject/ooni-probe/ooni/runner.py", line 265, in runTestCasesWithInputUnit
    log.debug("Running test with this input %s" % test_input)
TypeError: not all arguments converted during string formatting
[D] testsEnded: Finished running all tests
[D] [tls_handshake.py] 0.0%
[D] [tls_handshake.py] 0.0%
[D] [tls_handshake.py] 0.0%
^CReceived SIGINT, shutting down.
Main loop terminated.

Child Tickets

Attachments (1)

ticket_txscapy-DummyPcapWriter-has-wrong-signature-2.txt (1.8 KB) - added by isis 7 years ago.
traceback #1: string format error in log call in runner

Download all attachments as: .zip

Change History (4)

Changed 7 years ago by isis

traceback #1: string format error in log call in runner

comment:1 Changed 7 years ago by isis

Status: newneeds_revision

fixed in branch feature/tls-handshake-rebased, commit f1f236a61f46aeb890c64e51e8d150ce9599ff23

comment:2 Changed 7 years ago by isis

Status: needs_revisionneeds_review

Oops, make that a status change to 'Needs code/patch review'...

comment:3 Changed 6 years ago by isis

Resolution: fixed
Status: needs_reviewclosed

ooni-probe switched to using director.py and managers.py, and runner.py (which contained runner.runTestCases(), the function which caused this error) no longer exists.

Note: See TracTickets for help on using tickets.