Opened 11 years ago

Last modified 10 years ago

#834 closed defect (Fixed)

Tab restore does not work with FF 3.0.3 & TB 1.2.0

Reported by: d-man97 Owned by:
Priority: High Milestone:
Component: Applications/Torbutton Version: 1.2.0rc5
Severity: Keywords:
Cc: d-man97, Frankenstien, arma, mikeperry Actual Points:
Parent ID: Points:
Reviewer: Sponsor:

Description

Torbutton Preferences > Security Settings:
(1=checked, 0=un-checked)
Dynamic Content: 1 1 1 0 1 1 0 1 1 0
History: 1 1 1 0 0 0
Forms: 1 0
Cache: (1 0)
Cookies: (0 1 0 0) 1(greyed out) 0 1 1
Startup: (0 1 0) (0 1) 0 0
Shutdown: (0 1 0)
Headers: 1 1 1

As figured out on http://bugs.launchpad.net/bugs/279774, in order for tab restore to work:
1) Firefox Prefs > Privacy > Private Data "Settings..." > 'Browsing History' must not be checked.
2) In addition, Firefox Prefs > Privacy > "Keep my history..." must be checked and set to 1 or more days.

With those settings and Torbutton Extension disabled (completely off, no icon, no nothing) tab restore works fine.
I re-enable Torbutton, restart as told by Firefox, and verify that tor is toggled off (as it has been this whole time).
Open tabs, close, select save & quit, re-open Firefox, a blank page is displayed. Tab restore does not work.

I have Torbutton forget tor tabs/pages, so I am only concerned with restoring non-tor pages.

With no Torbutton settings set to mess with non-tor pages and non-tor history, I cannot fathom why this is happening.

P.S. I consider this critical because Torbutton is REMOVING data that I tell Firefox to save.

[Automatically added by flyspray2trac: Operating System: All]

Child Tickets

Attachments (1)

torbutton-1.2.0-dev.xpi.2 (205.1 KB) - added by mikeperry 10 years ago.
Torbutton with sessionstore fixes.

Download all attachments as: .zip

Change History (10)

comment:1 Changed 11 years ago by Frankenstien

... bump ... by FFF ... from Task #830 ...

comment:2 Changed 10 years ago by Frankenstien

Mike Perry ... what are the practical implications of the changes you made to this task on 16JAN09 as per the History of this task?
Thanks, Frankenstien

comment:3 Changed 10 years ago by mikeperry

Critical should be reserved for security bugs or cases where the browser is totally unusable. I set the bug to High/High.

comment:4 Changed 10 years ago by mikeperry

Ok, the pref that seems to be causing this is "Prevent session store from saving Tor loaded tabs"..
Not sure why it is breaking the whole session store though. Still looking into that.

comment:5 Changed 10 years ago by mikeperry

ok, this should be fixed in r18698, which will be in 1.2.1.

Changed 10 years ago by mikeperry

Attachment: torbutton-1.2.0-dev.xpi.2 added

Torbutton with sessionstore fixes.

comment:6 Changed 10 years ago by mikeperry

Actually, can you guys try out the torbutton in the attachments tab and let me know if it solves the issue
for you?

comment:7 Changed 10 years ago by Frankenstien

OK, I have installed 'torbutton-1.2.0-dev.xpi' (released by Mike Perry 05MAR09 here on 'Attachments' tab) on Mozilla Firefox 3.0.6 and preliminary testing shows that previously open windows and tabs are correctly restored (after a normal shutdown) on normal re-start of Ff browser with Torbutton state set to 'Tor Enabled' before and after restart (as per my Torbutton Preferences setting). I note that my previous Ff Tools > Add-ons > (Torbutton 1.2.0-dev) Options > Torbutton Preferences settings were unchanged by the install of the new '*.xpi'. Will report back if anything unexpected crops up in further usage testing.
Thank you Mike Perry for your efforts in working on Torbutton ... Frankenstien

comment:8 Changed 10 years ago by Frankenstien

damn that line return ... keep forgetting ... FFF

comment:9 Changed 10 years ago by mikeperry

flyspray2trac: bug closed.
Two users have confirmed this fixed their session store issues.

Note: See TracTickets for help on using tickets.