Opened 7 years ago

Closed 7 years ago

#8370 closed defect (fixed)

torflow checks out old torctl as submodule

Reported by: arma Owned by: aagbsn
Priority: Medium Milestone:
Component: Core Tor/Torflow Version:
Severity: Keywords:
Cc: mikeperry, aagbsn Actual Points:
Parent ID: Points:
Reviewer: Sponsor:

Description

bwauth@moria:~/work$ git clone https://git.torproject.org/git/torflow.git
Cloning into torflow...
remote: Counting objects: 3757, done.
remote: Compressing objects: 100% (1055/1055), done.
remote: Total 3757 (delta 2668), reused 3718 (delta 2647)
Receiving objects: 100% (3757/3757), 1.13 MiB, done.
Resolving deltas: 100% (2668/2668), done.
bwauth@moria:~/work$ cd torflow
bwauth@moria:~/work/torflow$ ./add_torctl.sh 
Submodule 'TorCtl' (https://git.torproject.org/pytorctl.git) registered for path 'TorCtl'
Cloning into TorCtl...
remote: Counting objects: 725, done.
remote: Compressing objects: 100% (236/236), done.
remote: Total 725 (delta 491), reused 718 (delta 488)
Receiving objects: 100% (725/725), 187.32 KiB, done.
Resolving deltas: 100% (491/491), done.
Submodule path 'TorCtl': checked out '305a759d99dd01f60faed9aa036b37746d3c54c5'

305a759 is way old (the head is from Apr 2012). For example, it doesn't include aagbsn's fix from today.

What am I doing wrong?

Child Tickets

Change History (1)

comment:1 Changed 7 years ago by arma

Resolution: fixed
Status: newclosed

aaron fixed:

1) forcibly upgrade your torctl, even though it thinks it's already up-to-date

2) git add TorCtl
3) git commit TorCtl

It will then generate a git commit that sure looks like TorCtl is a file, but actually it's a submodule.

Note: See TracTickets for help on using tickets.