Opened 7 years ago

Closed 7 years ago

#8393 closed defect (fixed)

Don't warn when dirauths run a version that's too new

Reported by: Sebastian Owned by: karsten
Priority: Medium Milestone:
Component: Metrics Utilities Version:
Severity: Keywords:
Cc: Actual Points:
Parent ID: Points:
Reviewer: Sponsor:

Description

I'm running master on gabelmoo currently, and consensus-health is complaining about an unrecommended version. The check should probably be adapted to only list versions which are too old, like Tor does when deciding whether to warn or just give a notice. I'd prefer not to be notified at all in such a case, tho.

Child Tickets

Change History (2)

comment:1 Changed 7 years ago by karsten

Owner: set to karsten
Status: newaccepted

Sounds good.

comment:2 Changed 7 years ago by karsten

Resolution: fixed
Status: acceptedclosed

Fixed, though not exactly by checking whether a version is too new or too old. Here's the commit message:

Exclude authorities on .0 versions from check.

Authorities often run not-yet-released tor versions, which have version strings ending in "-dev". We ignore status tags in version checks, so a version string "0.2.4.10-alpha-dev" is okay as long as "0.2.4.10-alpha" is recommended. But "0.2.5.0-alpha-dev" was not okay, because there's no recommended version "0.2.5.0-alpha". Let's pretend versions ending in ".0" (plus status tag) are always okay. Shouldn't produce too many false negatives, but saves us from writing lots of version string parsing code.

Thanks for reporting this! Closing.

Note: See TracTickets for help on using tickets.