Opened 7 years ago

Closed 7 years ago

#8395 closed defect (wontfix)

Tor RPM .spec file missing in 0.2.4.10-alpha

Reported by: aagbsn Owned by:
Priority: Medium Milestone: Tor: 0.2.4.x-final
Component: Core Tor/Tor Version: Tor: 0.2.4.10-alpha
Severity: Keywords: tor-relay
Cc: Actual Points:
Parent ID: Points:
Reviewer: Sponsor:

Description

Here are some patches to re-add the rpm spec file. Seems to build and work fine on Fedora 18

Child Tickets

Attachments (2)

0001-Re-Add-tor.spec.in-for-building-RPM.patch (14.0 KB) - added by aagbsn 7 years ago.
Adds the rpm spec file tor.spec.in from Tor 0.2.3.25
0002-Add-doc-TODO-to-included-files.patch (726 bytes) - added by aagbsn 7 years ago.
Update doc/include.am to include doc/TODO

Download all attachments as: .zip

Change History (10)

Changed 7 years ago by aagbsn

Adds the rpm spec file tor.spec.in from Tor 0.2.3.25

Changed 7 years ago by aagbsn

Update doc/include.am to include doc/TODO

comment:1 Changed 7 years ago by nickm

Keywords: tor-relay added
Milestone: Tor: 0.2.4.x-final

We seem to have taken them out intentionally with 43c86bbc70afb585a71948d8c36b26160d8039e0. What does Ondrej think about putting them back in?

comment:2 Changed 7 years ago by hiviah

I don't mind putting them back. Currently there's a parallel repo used for RPM builds, where main Tor code is merged. I was planning to create F18 packages after upgrading feddei to F18 this week (missed the date F18 went stable after many delays).

Suggestions:

  1. Use tor.spec.in from my repo, this one is for 0.2.4.x, another one for 0.2.3.x stable
  2. Check changes done to Makefile.am, especially the dist-rpm target, they are related to EL5. I'd like to have one tor.spec.in that works for latest two EL and two latest Fedoras (EL5, EL6, F17 and F18 currently)
  3. We're currently debating maintainership of Tor Fedora packages with Paul Wouters and Jamie Nguyen.

comment:3 Changed 7 years ago by aagbsn

Whoops, I just discovered that conversation.
I can confirm that hiviah's spec file works on FC18, and contains an up-to-date changelog.

comment:4 Changed 7 years ago by hiviah

I pointed Jamie and Paul to this ticket. Quick summary from mails for desired changes to tor.spec.in and startup scripts:

  • Remove stuff for unused distros (Mandriva, SUSE, RedFlag...)
  • Remove the permission setting in %__mkdir_p -m and use the %attr already present for /var/{lib,log,run}/tor
  • Remove /var/tmp/tor (not packaged)
  • Use --defaults-torrc instead of hardcoded values and SIGINT with timeout instead of SIGTERM/SIGKILL in startup scripts (cf. Debian scripts)

comment:5 Changed 7 years ago by nickm

I'll do whatever if somebody points me to something looking like a consensus

comment:6 Changed 7 years ago by hiviah

nickm: sorry for the confusion, but I think the tor.spec.in shouldn't be merged into 0.2.4.x or 0.2.5.x. Keep the git repo as is. (Neither Paul Wouters nor Jamie Nguyen added any opinion.)

Details:

Today, I've built 0.2.4.11 RPM packages and cleaned up the historical SUSE, Madrake and RedFlag stuff from tor.spec.in. Making tor.spec.in an official part of the repo would mean that somebody would have to keep track of whatever changes that happened to the tor.spec.in file in my repo.

comment:7 Changed 7 years ago by hiviah

On the other hand, I don't expect the tor.spec.in will be changing much soon - mostly just changelog entries.

So if you want, merge the last tor.spec.in from rpm-release-0.2.4 branch that has gone through cleanup.

comment:8 Changed 7 years ago by nickm

Resolution: wontfix
Status: newclosed

I am fine with maintaining the spec file in the tor-rpm repository. Just talked to aagbsn and he seems to agree. Closing this.

Note: See TracTickets for help on using tickets.