Opened 5 years ago

Closed 5 years ago

#8434 closed defect (fixed)

Match new Tor Browser Bundle User-Agent in is_likely_tor_browser

Reported by: dcf Owned by: aallai
Priority: Medium Milestone:
Component: Archived/Flashproxy Version:
Severity: Keywords:
Cc: Actual Points:
Parent ID: Points:
Reviewer: Sponsor:

Description

We have:

var TBB_UA = "Mozilla/5.0 (Windows NT 6.1; rv:10.0) Gecko/20100101 Firefox/10.0";

My User-Agent is now:

              Mozilla/5.0 (Windows NT 6.1; rv:17.0) Gecko/20100101 Firefox/17.0

Let's match either.

Child Tickets

Change History (5)

comment:1 Changed 5 years ago by aallai

Status: new → needs_review

I patched this in the master branch of ​https://github.com/aallai/flashproxy.git.

The window.sessionStorage object of the new TB is not null though, so is_likely_tor_browser returns false and the badge doesn't disable.

comment:2 Changed 5 years ago by aallai

I have also removed the check for disabled DOM storage, since DOM storage is enabled for some domains in the latest TBB.

comment:3 Changed 5 years ago by arlolra

aallai I sent you pull: ​https://github.com/aallai/flashproxy/pull/1

comment:4 Changed 5 years ago by aallai

arlolra has kindly brought my branch up to snuff. I had not updated the comment and used the wrong condition...

comment:5 Changed 5 years ago by dcf

Resolution: → fixed
Status: needs_review → closed

Thanks to both of you, now merged.

Note: See TracTickets for help on using tickets.