Opened 7 years ago

Closed 7 years ago

Last modified 2 years ago

#8537 closed defect (fixed)

Fix sentence in gettor-spec.txt

Reported by: rodolfoferraz Owned by: rodolfoferraz
Priority: Very Low Milestone:
Component: Core Tor/Tor Version:
Severity: Normal Keywords: tor-spec, gettor-spec
Cc: Actual Points:
Parent ID: Points:
Reviewer: Sponsor:

Description

This is just a minor correction in the text from gettor-spec.

In section "1. Overview", the second sentence is:

In many countries and networks Tor's main website is blocked and would be Tor users are unable to download even the source code to the Tor program.

It probably should be:

In many countries and networks, Tor's main website is blocked and Tor users are unable to download even the source code to the Tor program.

Child Tickets

Change History (6)

comment:1 Changed 7 years ago by rodolfoferraz

I've made a patch that fixes this in a branch in my public repo

https://github.com/rcaferraz/torspec/tree/bug8537

Here's the difference:

https://github.com/rcaferraz/torspec/compare/bug8537

comment:2 Changed 7 years ago by rodolfoferraz

Actually, after talking about my ticket in #tor-dev, I figured out my patch is wrong. The words "would be" I had just cut off from the sentence didn't have any meaning for me, but as the velope fellow pointed out, it has a similar role in the sentence with the one which "wannabe" would have.

So the text refers to the people that could turn into Tor users. They are the "Would be Tor users". The only correction that applies to this text is an hyphen, according to velope. The correct sentence would, then, be:

In many countries and networks Tor's main website is blocked and would-be Tor users are unable to download even the source code to the Tor program.

Notice the "would-be" instead of "would be".
The comma I added before is optional, so I removed it.

The branch I mentioned above was made again, with the right correction:

https://github.com/rcaferraz/torspec/tree/bug8537

https://github.com/rcaferraz/torspec/compare/bug8537

I'm sorry for spending your time correcting a file because of just a freakin hyphen. The whole point here was just for me to understand the process of submitting a patch here in the bug-tracker. And I learned a lot with it, thanks to velope and asn in #tor-dev. I thought about giving up this ticket, but velope encouraged me to continue it.

comment:3 Changed 7 years ago by nickm

Resolution: fixed
Status: newclosed

Thanks; I've merged it!

(Don't worry about the English issues; "would-be" is a weird construction. For what it's worth, it's not exactly "wannabe": "wannabe" is pejorative, but "would-be" is neutral.)

comment:4 Changed 2 years ago by teor

Component: - Select a componentCore Tor/Tor
Severity: Normal

comment:5 Changed 2 years ago by teor

Keywords: torspec tor-spec gettor-spectorspec, tor-spec, gettor-spec

Consistently use tor-spec across all tickets (add tor-spec).

comment:6 Changed 2 years ago by teor

Keywords: torspec removed

Consistently use tor-spec across all tickets (remove torspec).

Note: See TracTickets for help on using tickets.