Opened 7 years ago

Closed 6 years ago

#8559 closed defect (duplicate)

New Identity still occasionally crashes

Reported by: mikeperry Owned by: mikeperry
Priority: High Milestone:
Component: Firefox Patch Issues Version:
Severity: Keywords: tbb-crash, MikePerry201304
Cc: ioerror, aagbsn Actual Points:
Parent ID: Points:
Reviewer: Sponsor:

Description

In #6386, we backported a Mozilla fix for crashes during cache clearing at shutdown in an attempt to fix New Identity crash/deadlock. It may have fixed some instances, but more still remain. I have experienced both hangs and crashes in builds since that patch was updated.

I also added some loglines to New Identity in the last TBB release, so we hopefully have a better shot of at least narrowing this down now.

If anyone hits this a lot, go into about:config and set extensions.torbutton.loglevel to 3 and extensions.torbutton.logmethod to 0 and then run ./start-tor-browser --debug.

If you get a hang, we might be able to track it down based on the last logline that gets written to the debug file created in your Tor Browser directory that way. Unless buffering somewhere ruins our day :/.

Note that this will also log URLs to that file, though.

Child Tickets

Change History (5)

comment:1 Changed 7 years ago by mikeperry

Keywords: MikePerry201304 added

comment:2 Changed 7 years ago by mikeperry

I got this assertion during New Identity in a TBB-2.3.25-6 debug build that was unfortunately stripped of symbols:

Apr 02 00:24:09.432 [info] (firefox:stderr): ###!!! ASSERTION: Tried to remove an object that's not tracked: 'state->IsTracked()', file ../../dist/include/nsExpirationTracker.h, line 127
Apr 02 00:24:09.432 [info] (firefox:stderr): ###!!! ASSERTION: Object is lying about its index: 'generation.Length() > index && generation[index] == aObj', file ../../dist/include/nsExpirationTracker.h, line 131

Looks very similar to #8618.

comment:3 Changed 7 years ago by mikeperry

See #8628 for a potential fix.

comment:4 Changed 7 years ago by mikeperry

Summary: New Identity still occasionally hangs and crashesNew Identity still occasionally crashes

Let's separate out hanging and crashing, esp since the crash is probably the image cache issue (which is unrelated to the hang, I've just discovered).

comment:5 Changed 6 years ago by mikeperry

Resolution: duplicate
Status: newclosed

Calling this a dup of #8628.

Note: See TracTickets for help on using tickets.