Opened 7 years ago

Closed 7 years ago

#8638 closed defect (fixed)

mkdir fails in test suite

Reported by: weasel Owned by:
Priority: Low Milestone: Tor: 0.2.4.x-final
Component: Core Tor/Tor Version: Tor: 0.2.4.11-alpha
Severity: Keywords: 024-deferrable
Cc: Actual Points:
Parent ID: Points:
Reviewer: Sponsor:

Description

Our ci has failed twice already in the test suite with this error:

13:00:02 dir/measured_bw: [forking] File exists
13:00:03 Can't create directory C:\Users\jenkins\\tor_test_3572:
13:00:03   [measured_bw FAILED]

drwx------+ 1 jenkins None 0 Apr 3 15:20 /c/Users/jenkins/tor_test_3572

Not sure what exactly is going on there. This is the only tor_test_%d directory in the user profile dir, and it has an mtime of a day earlier.

Child Tickets

Attachments (1)

0001-test.c-Try-to-create-a-more-random-temporary-directo.patch (2.1 KB) - added by weasel 7 years ago.

Download all attachments as: .zip

Change History (4)

comment:1 Changed 7 years ago by nickm

Keywords: 024-deferrable added
Milestone: Tor: 0.2.4.x-final

seems like we should

A) have tor's tests + tinytest + windows behave nicer together, by creating a tempdir only in the main tinytest process, and not in the subprocesses. An environment variable or command-line flag seems a likely way to pass the info to the subprocess.

B) Have the tempdir names be less likely to repeat. Adding a random string or the current time or both seems plausible.

I'd take a patch for either.

comment:2 Changed 7 years ago by weasel

Status: newneeds_review

comment:3 Changed 7 years ago by nickm

Resolution: fixed
Status: needs_reviewclosed

Looks okay to me. Merging that patch, and calling this "fixed enough."

Note: See TracTickets for help on using tickets.