Opened 7 years ago

Closed 7 years ago

#8652 closed defect (fixed)

[patch] Google Maps local_url exclusion

Reported by: kenyon Owned by: pde
Priority: Medium Milestone: HTTPS-E 3.2
Component: HTTPS Everywhere/EFF-HTTPS Everywhere Version: HTTPS-E 3.1.4
Severity: Keywords: httpse-ruleset-bug patch
Cc: Actual Points:
Parent ID: #8627 Points:
Reviewer: Sponsor:

Description

Clicking on a link in Google Maps which starts with http://maps.google.com/local_url gets redirected to the https version, which results in an error 400 from Google. This patch fixes the ruleset. Patch also attached as a file.

From e1c5af6dba40ebf3718763518e6d6ce555603f85 Mon Sep 17 00:00:00 2001
From: Kenyon Ralph <kenyon@kenyonralph.com>
Date: Fri, 5 Apr 2013 22:49:52 -0700
Subject: [PATCH] [GoogleMaps] exclude http://maps.google.com/local_url

These URLs return error 400 if rewritten to https, so exclude them.
---
 src/chrome/content/rules/GoogleMaps.xml |    4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/src/chrome/content/rules/GoogleMaps.xml b/src/chrome/content/rules/GoogleMaps.xml
index e04bb60..c7afc7b 100644
--- a/src/chrome/content/rules/GoogleMaps.xml
+++ b/src/chrome/content/rules/GoogleMaps.xml
@@ -11,6 +11,8 @@
 							-->
 		<exclusion pattern="^http://maps\.googleapis\.com/map(?:files/lib/map_1_20\.swf|sapi/publicapi\?file=flashapi)" />
 		<exclusion pattern="^http://maps\.google\.gr/transitathens" />
+		<exclusion pattern="^http://maps\.google\.com/local_url" />
+
 	<target host="maps.gstatic.com" />
 
 
@@ -31,4 +33,4 @@
 	<rule from="^https://maps\.googleapis\.com/map(files/lib/map_1_20\.swf|sapi/publicapi\?file=flashapi)"
 		to="http://maps.googleapis.com/map$1" downgrade="1" />
 
-</ruleset>
\ No newline at end of file
+</ruleset>
-- 
1.7.10.4

Child Tickets

Attachments (1)

0001-GoogleMaps-exclude-http-maps.google.com-local_url.patch (1.2 KB) - added by kenyon 7 years ago.
GoogleMaps ruleset patch

Download all attachments as: .zip

Change History (6)

Changed 7 years ago by kenyon

GoogleMaps ruleset patch

comment:1 Changed 7 years ago by kenyon

Keywords: httpse-ruleset-bug added

comment:2 Changed 7 years ago by kenyon

Keywords: patch added
Summary: Google Maps local_url exclusion[patch] Google Maps local_url exclusion

comment:3 Changed 7 years ago by kenyon

Milestone: HTTPS-E 3.1.5

comment:4 Changed 7 years ago by pde

Parent ID: #8627

comment:5 Changed 7 years ago by pde

Resolution: fixed
Status: newclosed

I've applied this in git.

Note: See TracTickets for help on using tickets.