bwauth files don't include opinions about Authorities

It appears that moria1's bwauth doesn't provide an opinion about moria1, or any authority for that matter.

And no authorities provide Measured lines for turtles.

I suspect there's code in the bwauth to skip measuring authorities.

That's going to be bad now that we've turned on #8435 (moved).

The right fix might be to change the bwauths. But for now I'm filing as a Tor bug until we figure out where to fix it.

added component::core tor/torflow parent::20797 priority::medium resolution::wontfix severity::normal status::closed tor-dirauth type::defect labels

Trac:
Cc: N/A to mikeperry, aagbsn

What would we like here for a Tor fix, assuming we do this in tor?

Trac:
Keywords: N/A deleted, tor-auth added

If we fix this in tor, i believe the fix is to give authorities a free pass, i.e. count them as measured and believe their claimed bandwidth.

Sketch of a fix in branch "bug8684"

Trac:
Status: new to needs_review

I found this in torflow.git/NetworkScanners/BwAuthority:

    if n.idhex in prev_consensus:
      if prev_consensus[n.idhex].bandwidth != None:
        prev_consensus[n.idhex].measured = True
        tot_net_bw += n.new_bw
      if IGNORE_GUARDS \
           and ("Guard" in prev_consensus[n.idhex].flags and not "Exit" in \
                  prev_consensus[n.idhex].flags):
        plog("INFO", "Skipping voting for guard "+n.nick)
        n.ignore = True
      elif "Authority" in prev_consensus[n.idhex].flags:
        plog("DEBUG", "Skipping voting for authority "+n.nick)
        n.ignore = True

Might be a quite easy fix on the bwauth side.

If it's really measuring but not voting there, then yeah, that does sound easy. Then again, the in-tor fix isn't hard either.

Replying to nickm:

If it's really measuring but not voting there, then yeah, that does sound easy. Then again, the in-tor fix isn't hard either.

I commented out those last three lines, and reran aggregate, and it produced a line about moria1.

That said, it didn't produce a line about turtles or tor26. I admit that I do not know why.

Replying to arma:

That said, it didn't produce a line about turtles or tor26. I admit that I do not know why.

Oh! I bet it's because neither of them have the Fast flag. #8688 (moved).

Trac:
Component: Tor to Torflow

I've been running this on moria1's bwauth and it seems to do what I want:

--- a/NetworkScanners/BwAuthority/aggregate.py
+++ b/NetworkScanners/BwAuthority/aggregate.py
@@ -752,9 +752,9 @@ def main(argv):
                   prev_consensus[n.idhex].flags):
         plog("INFO", "Skipping voting for guard "+n.nick)
         n.ignore = True
-      elif "Authority" in prev_consensus[n.idhex].flags:
-        plog("DEBUG", "Skipping voting for authority "+n.nick)
-        n.ignore = True
+#      elif "Authority" in prev_consensus[n.idhex].flags:
+#        plog("DEBUG", "Skipping voting for authority "+n.nick)
+#        n.ignore = True
 
   # Go through the list and cap them to NODE_CAP
   for n in nodes.itervalues():

The downside is that moria1 can't lie so well using maxadvertisedbandwidth.

If the plan is to fix this on the bwauth side, can we just turn this into a bwauth ticket?

The component is torflow already -- it'll be a couple more days before I can merge any patches. Is there a reason why we skipped measuring the authorities before?

Trac:
Status: needs_review to assigned
Owner: N/A to aagbsn

Replying to aagbsn:

Is there a reason why we skipped measuring the authorities before?

git show d80be0c8 is our best hope (it offers no insights). Mike is the best person to answer.

It might have been so the MaxAdvertisedBandwidth hack could still work for authorities (so the bwauths don't discover that they're secretly very fast, and pump up traffic to them).

Calling this a torflow issue.

Trac:
Milestone: Tor: 0.2.4.x-final to N/A

Turns out that tor-auth is for directory authority so make it clearer with tor-dirauth

Trac:
Keywords: tor-auth deleted, tor-dirauth added

This is clearly not a blocker. And we should either stop scanning authorities entirely (#20797 (moved)), or report correct results for them (#8684 (moved)).

Trac:
Reviewer: N/A to N/A
Severity: N/A to Normal
Parent: N/A to #20797 (moved)
Sponsor: N/A to N/A
Priority: High to Medium

Priorities and Severities in torflow are meaningless, setting them all to Medium/Normal.

aagbsn was the default owner, unassigning

Trac:
Owner: aagbsn to N/A