Opened 7 years ago

Closed 6 years ago

#8685 closed defect (fixed)

Document how authorities choose relay status flags

Reported by: arma Owned by:
Priority: Medium Milestone: Tor: 0.2.4.x-final
Component: Core Tor/Tor Version:
Severity: Keywords: tor-spec tor-auth
Cc: Actual Points:
Parent ID: Points:
Reviewer: Sponsor:

Description

#8273 and #8435 are confusing in part because we don't know what they're trying to do. We should decide what they ought to do (starting I guess with deciding with what we think they did), and document that in dir-spec (or somewhere else that's appropriate). That way when we find something weird looking, there's a way to decide whether it's a bug.

In an ideal world, in retrospect, this topic probably could have used a short proposal.

Child Tickets

Change History (10)

comment:1 Changed 7 years ago by nickm

Keywords: tor-auth added

comment:2 Changed 7 years ago by nickm

Status: newneeds_review

Please review torspec branch "bug8685" in my torspec repository.

comment:3 Changed 7 years ago by arma

Nodes that don't meet these criteria do not influence any
+   threshold calculations, and also cannot receive the Exit flag.

I thought we decided that the lack of exit flag assignment was unchanged by the recent patches? I think the current behavior is that your Exit flag state cannot change while you're an inactive relay.

comment:4 Changed 7 years ago by arma

    Authorities SHOULD 'disable' any relays in excess of 3 on any single IP.
    When there are more than 3 to choose from,

Not a bug in your patch, but I believe this number is 2 in reality.

comment:5 Changed 7 years ago by arma

(AuthDirMaxServersPerAddr)

comment:6 Changed 7 years ago by arma

Do we in fact believe that Fast and Guard are the only flags influenced by bandwidth?

comment:7 Changed 7 years ago by nickm

Replying to arma:

Nodes that don't meet these criteria do not influence any
+   threshold calculations, and also cannot receive the Exit flag.

I thought we decided that the lack of exit flag assignment was unchanged by the recent patches? I think the current behavior is that your Exit flag state cannot change while you're an inactive relay.

It's unchanged, but was undocumented. Perhaps it should say "...cannot have their exit status change" instead?

comment:8 in reply to:  6 Changed 7 years ago by nickm

Replying to arma:

Do we in fact believe that Fast and Guard are the only flags influenced by bandwidth?

Those are the only ones which are based on a threshold of bandwidth.

HOWEVER, all thresholds, including stability and uptime thresholds that influence other flags, are based on the set of nodes described in the new paragraph starting with "When computing thresholds based on a percentile of nodes." And nodes which don't have measured bandwidths are not considered when computing those thresholds, if there are enough bandwidth measurements.

comment:9 Changed 7 years ago by nickm

I've added a couple more commits to try to address the above stuff. Good now?

comment:10 Changed 6 years ago by nickm

Resolution: fixed
Status: needs_reviewclosed

Squashed and merged.

Note: See TracTickets for help on using tickets.